This repository has been archived by the owner on Feb 24, 2023. It is now read-only.
Fixing #530 by manually looking at #488 and reverting #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Nov 30, 2017
Simperfit
approved these changes
Nov 30, 2017
nicolas-grekas
approved these changes
Nov 30, 2017
dunglas
approved these changes
Nov 30, 2017
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
Nov 30, 2017
…rryan) This PR was merged into the 5.1.x-dev branch. Discussion ---------- Fixing #530 by manually looking at #488 and reverting Hi guys! #530 was basically meant to revert #488, but it was not done perfectly. I approved it too quickly - my apologies for that. This fixes #532 I looked at each line in #488 and manually (and carefully) changed the code to use the old service id's everywhere. I believe this should fix the issues! Cheers! Commits ------- cb0851b Fixing #530 by manually looking at #488 and reverting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
#530 was basically meant to revert #488, but it was not done perfectly. I approved it too quickly - my apologies for that. This fixes #532
I looked at each line in #488 and manually (and carefully) changed the code to use the old service id's everywhere. I believe this should fix the issues!
Cheers!