Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Release missing release assets #69

Closed
mbiang opened this issue Jan 21, 2019 · 7 comments
Closed

Github Release missing release assets #69

mbiang opened this issue Jan 21, 2019 · 7 comments
Assignees
Labels
bug Something isn't working ready to deploy

Comments

@mbiang
Copy link

mbiang commented Jan 21, 2019

Some release assets are missing on Github based assets.

Expected Behavior
The sensu-pushbullet-handler has several release assets defined in the Github repository for Release 0.0.4. After adding this asset to Bonsai, I expected to see these release assets listed in the sidebar of the Extension Page for version 0.0.4.

Additionally, I expect to be able to use the "Recompile Asset" function form the "Manage Asset" menu as the asset owner or site admin.

Current Behavior

  • No release assets show after adding the asset to the Bonsai index (they weren't found when initially scanning the Github repository).
  • The "Recompile Asset" feature doesn't pull in the release assets either.
@mbiang mbiang added the bug Something isn't working label Jan 21, 2019
@mbiang
Copy link
Author

mbiang commented Jan 22, 2019

This is due to to a whitespace syntax error in the bonsai.yml file.

Desired Behavior:

  • If the bonsai.yml file fails to parse, we should show an error message on the extension details page that informs the user that the bonsai.yml file could not be parsed.
  • This message should be displayed as a banner notification at the top of the extension details page. It should read something like - "The bonsai.yml file could not be parsed. Click here for more info". Clicking the link should expand the message to show the error details.
  • This should additionally appear on the right sidebar where the SHAs would normally appear.

@rgeniesse
Copy link

Here's the original issue with the bonsai.yml file as I have fixed it in master, so the above comment's link is no longer valid in showing the issue.

@mbiang
Copy link
Author

mbiang commented Jan 30, 2019

We are now showing asset compilation errors as part of #81, and now the sensu-pushbullet-handler asset indicates that the bonsai.yml file in version 0.0.6 is malformed, particular the 8th build section. When inspecting the bonsai.yml however, I only see seven build entries, so I'm not sure exactly what's wrong. We will continue to investigate.

@mbiang
Copy link
Author

mbiang commented Jan 30, 2019

@rgeniesse - Ahh, the issue I mentioned in my last comment has to do with the bad indentation in the bonsai.yml file. I didn't realize release 0.0.6 was issues prior to you making that change.

Regarding the master branch, I believe it won't show any release assets (since it's not a release and there's no way to attach binaries to master). @demillir does that sound right to you?

@rgeniesse - you could try cutting another release, and I your release assets should now show up, or you should see a syntax error message.

@rgeniesse
Copy link

@mbiang I've cut a new release and things look much better. This release includes the fix to the bonsai.yml file.

Getting an error about a compilation error for a windows build, CI shows it built so not sure what to make of that:

screen shot 2019-01-30 at 8 32 53 pm

I did have to re-compile after to get the rest of the rest of the release assets to show up, but I may also have been too impatient.

@mbiang mbiang assigned pzupan and unassigned demillir Feb 6, 2019
@pzupan
Copy link

pzupan commented Feb 8, 2019

Pull request #97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready to deploy
Projects
None yet
Development

No branches or pull requests

4 participants