Fix windows service management #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
requested changes
Aug 6, 2020
treydock
force-pushed
the
fix-windows
branch
2 times, most recently
from
b2c91e8
to
2f4cc17
Compare
Replace dsc_service with Exec that installs the sensu-client service Fixes #33
ghoneycutt
approved these changes
Aug 10, 2020
|
Cheers @treydock will try out the change this week to test and will advise. Shame about moving to an exec but not surprising about DSC being an issue really as I can see a gotcha you need to be aware of when using user rights assignment with multiple policies. |
|
@treydock @ghoneycutt I have tested out the change and looks good. It creates it correctly with identity info passed to it and starts the service when down without any issues. Cheers. Do you know when this might make it into PuppetForge as a version? |
|
@StuartMcManus This was released to PuppetForge as v3.6.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Replace dsc_service with Exec that installs the sensu-client service. All parameter behaviors are the same, the only change is how the service gets installed.
Related Issue
Fixes #33
Motivation and Context
This more closely matches the steps documented by Sensu for installing the client service on Windows.