Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix for all variables #16

Closed
lukyanov opened this issue Apr 17, 2016 · 2 comments
Closed

Prefix for all variables #16

lukyanov opened this issue Apr 17, 2016 · 2 comments

Comments

@lukyanov
Copy link
Contributor

Great experience overall with the role! Thank you for sharing this.

There is one thing I would suggest. It's a great practice to prefix all the variables of the role with the role name (sensu_). The practical reason for that is that you reduce the risk of interfering with the rest of the Ansible project you are working on.

It just happened to me. I have an independent RabbitMQ server absolutely not related to Sensu, just for some application purposes. I wanted to install a separate instance of a RabbitMQ server with your role. I spent quite some time figuring out why my own RabbitMQ server gets SSL keys and restarts while I'm provisioning my servers with your role :) Finally I realized that my server has an inventory variable rabbitmq_server which causes the role to do some actions for that.

@jaredledvina jaredledvina self-assigned this Nov 28, 2017
@jaredledvina
Copy link
Contributor

Hey @lukyanov,
Sorry again that you didn't get a follow up to this sooner! This is a totally fair ask and something I can work on putting together. If you feel like throwing in a PR as well, I'm happy to review/test it out.

This was referenced Feb 17, 2018
@jaredledvina jaredledvina removed their assignment Nov 3, 2018
michaelpporter added a commit to michaelpporter/sensu-ansible that referenced this issue Feb 18, 2019
This is an attempt at sensu#16. It has breaking changes if merged due to the variables and group namges changing.
jaredledvina added a commit that referenced this issue Feb 19, 2019
fix(issues) Attempt to address #16
Prefix all variables with sensu_
@jaredledvina
Copy link
Contributor

Finally closed out in https://github.com/sensu/sensu-ansible/releases/tag/5.0.0 via #206

This was delayed for far too long but, we finally got it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants