-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -ignore-initial-run flag and update changelog #7
Conversation
Signed-off-by: Nikki Attea <nikki@sensu.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If -ignore-initial-run is true, there is no reason to read through the file. The program could just initialize the state file and exit. Can you look into doing that? It would likely speed up the first execution quite dramatically. :)
Signed-off-by: Nikki Attea <nikki@sensu.io>
@echlebek I used the presence of the state file, rather than the offset, to determine if the plugin is on it's first run. Let me know if this approach is more in line with your suggestion. |
I worry it doesn't address the number of matches described in #6 (comment) though. We'd have to read through the log file to determine the initial matches. |
Signed-off-by: Nikki Attea <nikki@sensu.io>
Signed-off-by: Nikki Attea <nikki@sensu.io>
I've set the state file's offset on the first run with |
Signed-off-by: Nikki Attea <nikki@sensu.io>
Signed-off-by: Nikki Attea <nikki@sensu.io>
Signed-off-by: Nikki Attea nikki@sensu.io
Closes #5
Closes #6