Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Page rating function is not keyboard-accessible #4108

Open
1 of 2 tasks
hillaryfraley opened this issue Nov 3, 2022 · 1 comment
Open
1 of 2 tasks

Comments

@hillaryfraley
Copy link
Contributor

hillaryfraley commented Nov 3, 2022

Description

The entire page rating function at the top-right of the docs pages is not keyboard-accessible. Also tested with macOS VoiceOver.

Category

This is an issue with:

  • bug (bug in site build, layout, or functionality)
  • enhancement (add new or updated site functionality)

Affected pages

https://github.com/sensu/sensu-docs/blob/main/layouts/partials/contribute.html

Expected behavior

Users can navigate to the rating function on the page and select a rating using only their keyboard

Current behavior

Keyboard navigation (via tab button and via VoiceOver controls) skips from the end of the main content section to the first item in the right-nav menu

Changes needed

Unsure -- maybe add tabindex="0" to the divs.

@hillaryfraley
Copy link
Contributor Author

I've done a little more investigation and testing.

If I add tabindex="0" to the div, I can tab to the entire ratings item but not to the individual rating options:
tabindex-div

If I add tabindex="0" to the label for each rating option, I can tab to the individual rating options:
tabindex-labels

Even though I can navigate to each rating option with tab, I cannot select a rating option with the space bar or Enter key.

Adding tabindex="0" to the input tag for each rating option does not work (cannot tab to individual rating options).

Another issue is it seems the tabindex="0" should not be necessary for radio buttons to be keyboard accessible -- the type="radio" should be sufficient, but in this case it doesn't seem to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant