Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handler Hooks #702

Closed
12 tasks
nikkictl opened this issue Dec 7, 2017 · 4 comments
Closed
12 tasks

Handler Hooks #702

nikkictl opened this issue Dec 7, 2017 · 4 comments
Labels

Comments

@nikkictl
Copy link

nikkictl commented Dec 7, 2017

Extend hook functionality to handlers! A handler hook will respond to handler results in the same way that a check hook responds to check results. Response codes (HookList type) can range from “1”-“255” or can fall under one of the following severities: "ok", "warning", "critical", "unknown", "non-zero”. The owner of this ticket can, and probably should, explode out the suggested subtasks.

  • add a HookList to handler.proto repeated HookList handler_hooks
  • regenerate protobufs with scripts/genproto.sh
  • AddHandlerHook function in handler backend
  • add_hook command in handler cli
  • addHandlerHook route in handler router
  • RemoveHandlerHook function in handler backend
  • remove_hook command in handler cli
  • removeHandlerHook route in handler router
  • retrieve and store all Hooks associated with a handler
  • execute handler hooks upon receiving handler result
  • implement the hook stdin at execution
  • corresponding validators, tests, etc.
@grepory
Copy link
Contributor

grepory commented Nov 23, 2018

We can revisit this if it's requested.

@grepory grepory closed this as completed Nov 23, 2018
@majormoses
Copy link

majormoses commented Nov 23, 2018

I think handler hooks make a lot of sense, it allows you to deal with failure scenarios with handlers which often rely on external solutions/providers. For example if a service such as pagerduty is down, hit a rate limit, or authentication issues I would like to be able to send something like a slack message to notify the operators.

@grepory
Copy link
Contributor

grepory commented Nov 23, 2018

We can leave it on the backlog.

@grepory grepory reopened this Nov 23, 2018
@calebhailey calebhailey added the component:backend Sensu Backend improvements label Apr 5, 2020
@echlebek
Copy link
Contributor

We haven't seen much demand or traction on this issue and it's getting quite old now. I'm going to close it. If we see revived interest, we can always file a new issue or open this one again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants