[Web UI] Avoid relative imports with module-resolver plugin #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10xjs
force-pushed
the
web/babel-module-resolver
branch
from
090d113
to
a823d17
Compare
Any absolute es6 import statement is resolved relative to the `src` directory. This avoids the need to use deep relative paths that reference a file's current location. Compared to a set of webpack aliases to specific directories within the project, this approach is more flexible, less fragile, and easier to reason. In order to use `eslint-import-resolver-babel-module`, `babel-preset-react-app` had to be abandoned. The new `.babelrc` file is a simplified copy of the previous preset. Signed-off-by: Neal Granger <neal@nealg.com>
10xjs
force-pushed
the
web/babel-module-resolver
branch
from
a823d17
to
834fc8a
Compare
|
Build failure appears to be related to golang/lint#397. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
Any absolute es6 import statement is resolved relative to the
srcdirectory.Compared to a set of webpack aliases to specific directories within the project, this approach is more flexible, less fragile, and easier to reason.
Why is this change necessary?
This avoids the need to use deep relative paths that reference a file's current location making the app far easier to organize. This effectively allows any file in
srcto be referenced as a namespaced module, akin to any of the npm dependencies.Does your change need a Changelog entry?
Nah.
Do you need clarification on anything?
Nah.
Were there any complications while making this change?
In order to use
eslint-import-resolver-babel-module,babel-preset-react-apphad to be abandoned. The new.babelrcfile is a simplified copy of that preset preserving compatibility.