Trim whitespace from check output in opentsdb transformer #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ases with whitespace Signed-off-by: Nikki Attea <nikki@sensu.io>
palourde
approved these changes
May 7, 2018
|
@palourde yes I added test cases for all transformers with trailing whitespaces. I believe the nagios transformer is unaffected since we do not attempt to parse multiple lines of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikki Attea nikki@sensu.io
What is this change?
Fixed a small bug in the opentsdb transformer so that it trims trailing whitespace characters.
Why is this change necessary?
Check output containing one or multiple metrics in opentsdb metric format can also contain trailing whitespace or newline characters. We should not attempt to parse the newline character for a metric, rather we should ignore it.
Does your change need a Changelog entry?
Yas.
Do you need clarification on anything?
Nah.
Were there any complications while making this change?
Nah.