Use asset build with most specific filters #4990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
Updates
asset.FilteredManagerto evaluate all asset build filters and returns the asset build with the most specific (highest number of filters) matching the entity. This is a breaking change as it can alter which asset build is installed on existing clusters.Why is this change necessary?
Closes #3655
Closes #4455
Does your change need a Changelog entry?
Yes.
Do you need clarification on anything?
No.
Were there any complications while making this change?
No.
Have you reviewed and updated the documentation for this change? Is new documentation required?
The docs should be updated to describe this behaviour.
sensu/sensu-docs#4185
How did you verify this change?
I used TDD to define the behaviour before I made the change. The tests should be sufficient.
Is this change a patch?
No.