Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update puppet versions, add ruby 2.0, remove ruby-head #111

Merged
merged 2 commits into from
Dec 1, 2013
Merged

update puppet versions, add ruby 2.0, remove ruby-head #111

merged 2 commits into from
Dec 1, 2013

Conversation

jlambert121
Copy link
Contributor

No description provided.

@jamtur01
Copy link
Contributor

Awesome stuff. Could you please investigate the failed tests? Thanks!

@jlambert121
Copy link
Contributor Author

Absolutely - forgot to return to this after travis ran. Travis didn't seem to honor the excludes in the matrix - going to start with that and see what's left.

@jlambert121
Copy link
Contributor Author

OK - I have no idea why travis isn't honoring the exclude matrix - any thoughts? That block is identical to what my modules have.

The other error is JSON ordering - any thoughts on what the best way to deal with that is? I could use only one parameter with custom and make it pass but testing for the JSON seems like a good thing to do.

@jamtur01
Copy link
Contributor

It looks identical to mine too. Checked the TravisCI docks and they look right too. Weird.

I'd force order on the JSON?

@jlambert121
Copy link
Contributor Author

I'll hop on IRC and ask in #travis.

I'd love to force order on the JSON, but the spec doesn't guarantee order as far as I've been able to tell. Do you know of any magic to do it?

@jamtur01
Copy link
Contributor

Hmm I thought I could find an ordering workaround but it seems not.

@jamtur01
Copy link
Contributor

Perhaps the include matcher? http://rubydoc.info/gems/rspec-expectations/RSpec/Matchers:include

@jamtur01
Copy link
Contributor

@jlambert121
Copy link
Contributor Author

The == makes sense since it's comparing data structures, but I'm not sure how to implement that within puppet-rspec.

@jamtur01
Copy link
Contributor

I'm going to ask @rodjek :)

@jlambert121
Copy link
Contributor Author

Perfect! You'll likely get more of a response than me. :)

@jlambert121
Copy link
Contributor Author

The travis channel on freenode has been unhelpful on the exclusion matrix. Any other thoughts on it? Any response from @rodjek on the json/hash comparison?

@jamtur01
Copy link
Contributor

Apparently support for what we want is in master of puppet-rspec but not yet released. :(

jamtur01 added a commit that referenced this pull request Dec 1, 2013
update puppet versions, add ruby 2.0, remove ruby-head
@jamtur01 jamtur01 merged commit 4944f72 into sensu:master Dec 1, 2013
@jamtur01
Copy link
Contributor

jamtur01 commented Dec 1, 2013

Merging this as the test can't be fixed right now.

@jlambert121
Copy link
Contributor Author

Version 1.0.0 of rspec-puppet is out - should fix the hash ordering issue. Still no clue on the test matrix though.

@jlambert121 jlambert121 deleted the travis_update branch December 26, 2013 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants