-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update puppet versions, add ruby 2.0, remove ruby-head #111
Conversation
Awesome stuff. Could you please investigate the failed tests? Thanks! |
Absolutely - forgot to return to this after travis ran. Travis didn't seem to honor the excludes in the matrix - going to start with that and see what's left. |
OK - I have no idea why travis isn't honoring the exclude matrix - any thoughts? That block is identical to what my modules have. The other error is JSON ordering - any thoughts on what the best way to deal with that is? I could use only one parameter with custom and make it pass but testing for the JSON seems like a good thing to do. |
It looks identical to mine too. Checked the TravisCI docks and they look right too. Weird. I'd force order on the JSON? |
I'll hop on IRC and ask in #travis. I'd love to force order on the JSON, but the spec doesn't guarantee order as far as I've been able to tell. Do you know of any magic to do it? |
Hmm I thought I could find an ordering workaround but it seems not. |
Perhaps the include matcher? http://rubydoc.info/gems/rspec-expectations/RSpec/Matchers:include |
The == makes sense since it's comparing data structures, but I'm not sure how to implement that within puppet-rspec. |
I'm going to ask @rodjek :) |
Perfect! You'll likely get more of a response than me. :) |
The travis channel on freenode has been unhelpful on the exclusion matrix. Any other thoughts on it? Any response from @rodjek on the json/hash comparison? |
Apparently support for what we want is in master of puppet-rspec but not yet released. :( |
update puppet versions, add ruby 2.0, remove ruby-head
Merging this as the test can't be fixed right now. |
Version 1.0.0 of rspec-puppet is out - should fix the hash ordering issue. Still no clue on the test matrix though. |
No description provided.