Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support redis sentinels and add master property #509

Merged
merged 2 commits into from
Jul 23, 2016

Conversation

modax
Copy link
Contributor

@modax modax commented Jun 10, 2016

Hello,

this PR adds support for redis sentinels (since sensu 0.23) and adds master property for redis sentinels config (undocumented sensu 0.23 feature). It is somewhat inspired on PR #496 but:

  1. No sentinel unrelated changes in the code.
  2. Code should be cleaner (I have kept the same type / provider for redis config with sentinels)
  3. host, port, master, sentinels properties are properly removed from redis.json once they are removed from puppet config or when "connection type" changes.
  4. New tests for sentinels.
  5. Support for 'master' property Search Doesn't Appear to Fully Work sensu-docs#380

It would be great if you could release a new version with this PR. Thank you.

Available since sensu 0.23 but currently undocumented. See:

sensu/sensu-docs#380
@modax
Copy link
Contributor Author

modax commented Jun 13, 2016

Quick note, Puppet 4 tests are failing due to Puppet 4.5 (previous master branch was built with Puppet 4.4) which is unrelated to this PR.

@RiRa12621
Copy link
Contributor

+1

@jaxxstorm
Copy link
Contributor

@jamtur01 @jlambert121 any chance we can get this merged?

If you guys don't have time to manage the module, any chance you add another participant so they can help manage the module?

/cc @portertech

@jaxxstorm
Copy link
Contributor

closes #514 #499

@jaxxstorm jaxxstorm merged commit 420a478 into sensu:master Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants