Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation visual only one left bug to fix #77

Closed
PhilZ-cwm6 opened this issue May 14, 2020 · 4 comments
Closed

Rotation visual only one left bug to fix #77

PhilZ-cwm6 opened this issue May 14, 2020 · 4 comments

Comments

@PhilZ-cwm6
Copy link
Contributor

PhilZ-cwm6 commented May 14, 2020

Thank you a lot, last commit fixed all functional bugs due to rotation.
I found a few more visual only bugs. Functionality is preserved, so really not a big issue in reliability of sync edit. All are fixed by my last commit except :

This one needs to save/restore the browsing path view

  • Edit master/target folder rotation: enable rotation and List Folders visual bug
    This includes the way to enable rotation in edit master/target folders
    • phone in portrait mode
    • click to edit an existing task with master as Internal Storage
    • turn phone in landscape mode
    • click master folder (1)
    • List Directories
    • select a subdirectory
    • back to portrait mode
    • the proper directory is selected (.../Android/obb/ in my example) but the folders view is always back to root of master
    • the bug is only visual because when you click Ok, the proper Android/obb folder is selected
      also, all menus are perfectly saved/restored on rotation

(1) When entering Tagert/master folders edit dialog in portrait, we can no rotate.
This exact step enables rotation into the edit master folder view

Screenshot_1589445192

Screenshot_1589445120

  • Edit master/target folder rotation in Archive mode: layout gap and file types gone visual bug

    • Archive mode
    • enable rotation in target folder edit view like in first step (1)
    • back to portrait
    • A long gap is created to access "Only files with following extensions will be archived..."
      we need to scroll down to see the options
    • the file extensions are no longer displayed (reveals bug in landscape display on small devices)
    • the bug is only visual because all menus are perfectly saved/restored on rotation

This one is fixed by this commit: #78

Screenshot_1589445837

Screenshot_1589445852

Screenshot_1589447724

@PhilZ-cwm6
Copy link
Contributor Author

PhilZ-cwm6 commented May 14, 2020

I edit my issue
All were fixed in this commit: #78

Even the last one is fixed now by the commit
Remains only the first issue to save/restore browsing path

After that, the rotation mode will be perfectly working in Edit master/target folders.
It would really be great that you enable back rotation in Edit master/target folder instead of blocking my way to access it.

Thank you for the quick follow-up

@PhilZ-cwm6 PhilZ-cwm6 changed the title Rotation visual only bugs to fix Rotation visual only one left bug to fix May 14, 2020
@Sentaroh
Copy link
Owner

Thank you.

1.Fixed a bug where the list of files displayed when the screen is rotated would return to the default value.(Utilities/CommonFileSelector.java)
2.Fixed a bug where fixScreenOrientation() didn't work on Landscapes.

@PhilZ-cwm6
Copy link
Contributor Author

Thank you,
The Utilities lib update works perfectly
Can you revert the rotation block ? Everything works perfectly now

@Sentaroh
Copy link
Owner

Supported reloading the Layout when the screen is rotated when editing SyncFolder. (remove fix/unfix function)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants