Planetscope veg indices #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 20, 2024 14:11
chorng
requested changes
Jun 21, 2024
There was a problem hiding this comment.
Look good to me! I added some minor comments there. Please also add links to the planet_scope markdown otherwise your page can only be found by the search bar.
planet_scope/max_ndvi/script.js
Outdated
| else if (max<0.5) return [0.19,0.43,0.11]; | ||
| else if (max<0.55) return [0.13,0.38,0.07]; | ||
| else if (max<0.6) return [0.06,0.33,0.04]; | ||
| else return [0,0.27,0]; |
There was a problem hiding this comment.
If NaN is returned when denom == 0, it can be used to create a dataMask and we can return the dataMask in the 4th band.
There was a problem hiding this comment.
would rather keep it the same as the Sentinel-2 script.
| layout: script | ||
| permalink: /planet_scope/ndvi_difference/ | ||
| nav_exclude: true | ||
| scripts: |
There was a problem hiding this comment.
I think this is too complicated as we are using multiple acquisitions in this instance. In the difference script there is a before and after. For precedent the Sentinel-2 version of this script does not have an eob version.
chorng
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added two NDVI scripts to Planetscope:
I think the description has been setup correctly but if not we can look next week.