Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features: Create an inference python file #35

Closed
seoulsky-field opened this issue Dec 26, 2022 · 0 comments
Closed

Features: Create an inference python file #35

seoulsky-field opened this issue Dec 26, 2022 · 0 comments
Assignees
@kdg1993 @juppak @seoulsky-field @jieonh @chrstnkgn
Labels
Discussion Extra attention is needed Features New feature or request Inference About benchmark inference file
Milestone
Modality: X-ray

Comments

@seoulsky-field
Copy link
Owner

What

While we discussed about how we get model weights from directory when doing model soups, we noticed that we should create an inference(benchmark) python file.

Why

There are many benchmark githubs have an inference python file(or benchmark python file). Also, some of the functions we'll support need inference file.

How

Can reference validation function that is already existed in train.py.
Also, we'll reference lots of benchmark githubs from NeurIPS, MICCAI, etc.
Any opinions welcome!
@seoulsky-field seoulsky-field added the Features New feature or request label Dec 26, 2022
@seoulsky-field seoulsky-field added the Discussion Extra attention is needed label Dec 26, 2022
@jieonh jieonh mentioned this issue Dec 29, 2022
Closed
@seoulsky-field seoulsky-field added this to the Dataset: CheXpert milestone Dec 30, 2022
jieonh added a commit that referenced this issue Jan 2, 2023
@jieonh
Merge: branch develop into feature/#35
d25542b
@jieonh jieonh mentioned this issue Jan 2, 2023
Merged
jieonh added a commit that referenced this issue Jan 3, 2023
@jieonh
Merge pull request #45 from yisakk/feature/#35
63b59fb 
Resolved: Feature/#35, #40
@jieonh jieonh closed this as completed Jan 3, 2023
@seoulsky-field seoulsky-field added the Inference About benchmark inference file label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdg1993 kdg1993

@juppak juppak

@seoulsky-field seoulsky-field

@jieonh jieonh

@chrstnkgn chrstnkgn

Labels
Discussion Extra attention is needed Features New feature or request Inference About benchmark inference file
Projects
None yet
Milestone
Modality: X-ray
Development

No branches or pull requests
5 participants
@kdg1993 @juppak @seoulsky-field @jieonh @chrstnkgn