Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved: Feature/#15 #24

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Resolved: Feature/#15 #24

merged 2 commits into from
Dec 21, 2022

Conversation

chrstnkgn
Copy link
Collaborator

Motivation 🤔


Key Changes 🔑

  • WandB Issue
    👍 WandB is applied for our default running!

    1. The name of each experiment is saved as Y-M-D_H-M-S (same as the hydra logdir name)

    2. val_loss, batch_id, epochs, val_score, and best_val_score are logged
      image

    3. Different configs that we want to identify for each run are logged as a table
      image

    👎 Could not implement these settings to Ray

    • When applying hyperparameter search using Ray Tune, the WandB logger is still applied using ray-embedded WandBCallbackLogger but the output log is too much in detail which we are not fond of.

  • Seed fixing issue

    👍 Implemented seed fixing code to train.py


To Reviewers 🙏

  • Ray update needed (pip install -U ray[default]==2.2.0) if you want to test with ray
  • For testing purposes: you can modify 'project' value in config/logging/wandb.yaml file so you can control and keep track of your experimental trials.

resolved: #15
references:

@chrstnkgn chrstnkgn self-assigned this Dec 21, 2022
@chrstnkgn chrstnkgn added the Features New feature or request label Dec 21, 2022
@chrstnkgn chrstnkgn linked an issue Dec 21, 2022 that may be closed by this pull request
3 tasks
@juppak
Copy link
Collaborator

juppak commented Dec 21, 2022

Thanks a lot!
I updated ray and tested it as you said. 😁

@chrstnkgn
Copy link
Collaborator Author

If you're all good with this pr I'll just merge it!

@chrstnkgn chrstnkgn merged commit 6b6f63d into develop Dec 21, 2022
@chrstnkgn chrstnkgn deleted the feature/#15 branch December 21, 2022 01:29
@kdg1993
Copy link
Collaborator

kdg1993 commented Dec 21, 2022

Beautiful work!! 👍

While I'm trying to test these new changes, a pip install error occurred.

I used the exact command that @chrstnkgn mentioned in her PR "pip install -U ray[default]==2.2.0"
image

There has been no other error since then, but I'm leaving it for recording just in case 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Features New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Features: WandB logging part as a Hydra option
3 participants