Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update writable_alphabet concept #278

Closed
4 tasks
smehringer opened this issue Jan 11, 2021 · 0 comments · Fixed by seqan/seqan3#2337
Closed
4 tasks

Update writable_alphabet concept #278

smehringer opened this issue Jan 11, 2021 · 0 comments · Fixed by seqan/seqan3#2337
Assignees
@MitraDarja

Comments

@smehringer
Copy link
Member

Description

Currently the writeable_alphabet concept requires seqan3::char_is_valid_for. char_is_valid_for is not used very often yet so it should not be part of the concept for seqan 3.1.

If it will be used more often we can add a strictly_writeable_alphabet that also considers seqan3::assign_char_strictly_for.

Tasks

  • Remove the seqan3::char_is_valid_for from the seqan3::writeable_alphabet
  • Check and adapt documentation if necessary
  • Check and adapt tutorials if necessary
  • Changelog entry added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MitraDarja MitraDarja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MISC] Update writable_alphabet concept MitraDarja/seqan3
2 participants
@smehringer @MitraDarja