Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when augmenting with a sha256 tag #477

Open
ewels opened this issue Apr 29, 2024 · 1 comment
Open

Improve error message when augmenting with a sha256 tag #477

ewels opened this issue Apr 29, 2024 · 1 comment

Comments

@ewels
Copy link
Member

ewels commented Apr 29, 2024

As documented in #448, Wave cannot support SHA256 tags when augmenting an image, because the image itself is changing.

When someone attempts to do this, the following error is returned:

Container requests made using a SHA256 as tag does not support the 'containerConfig' attribute

(I'm not sure where this error message is coming from, as I can't find it in the source code of the Wave or Nextflow repos).

This error mode is likely going to be quite common as people take existing pipelines with fixed SHA256 tags and enable Wave. It would be great if we could improve the error message to (a) make it easier to understand and (b) explain how to fix the issue - point to the docs.

Basically, no-one getting this error is going to be trying to use the 'containerConfig' attribute intentionally (I don't know even what that is). So we should instead throw an error message about SHA256 tags and Wave augmentation.

@pditommaso
Copy link
Contributor

This is solved, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants