Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe use of sha256 hash with Wave #448

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Describe use of sha256 hash with Wave #448

merged 5 commits into from
Apr 29, 2024

Conversation

jason-seqera
Copy link
Contributor

So this is an early draft that seeks to clarify this use case.

@jason-seqera jason-seqera added the documentation Improvements or additions to documentation label Apr 9, 2024
@jason-seqera jason-seqera self-assigned this Apr 9, 2024
@marcodelapierre
Copy link
Member

Thanks for actioning this @jason-seqera !

I really like the perspective you gave to this paragraph. I now actually realise it might even have a better location under the Tutorials section.

docs/guide.md Outdated Show resolved Hide resolved
docs/guide.md Outdated Show resolved Hide resolved
docs/guide.mdx Outdated Show resolved Hide resolved
docs/guide.mdx Outdated Show resolved Hide resolved
jason-seqera and others added 2 commits April 17, 2024 14:10
Co-authored-by: Phil Ewels <phil.ewels@seqera.io>
docs/guide.mdx Outdated
Comment on lines 70 to 77
You can run `nextflow inspect` to find the SHA256 hash of the Wave augmented container.

In your pipeline, you can use the SHA256 of the Wave augmented container, available in the target repository that you specify with the `wave.build.repository` parameter. For example:

```groovy
docker.enabled = true
process.container = 'docker.io/<user>/my-bio-container@sha256:3235....ce8f'
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what this means

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It comes from the discussion thread above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made no sense to me. I have rewritten it

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso pditommaso merged commit 2cd00be into master Apr 29, 2024
1 check passed
@pditommaso pditommaso deleted the nf-tower-docs-624 branch April 29, 2024 21:05
ewels added a commit that referenced this pull request May 7, 2024
Follow on from #448

Try to add a little more detail / explanation about exactly what this section is proposing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants