Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argument order of defaultSubscriber.start call #8

Merged
merged 1 commit into from
Aug 24, 2019
Merged

Fix argument order of defaultSubscriber.start call #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ros/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ func (node *defaultNode) NewSubscriber(topic string, msgType MessageType, callba
node.subscribers[name] = sub

logger.Debugf("Start subscriber goroutine for topic '%s'", sub.topic)
go sub.start(&node.waitGroup, node.masterUri, node.qualifiedName, node.xmlrpcUri, node.jobChan, logger)
go sub.start(&node.waitGroup, node.qualifiedName, node.xmlrpcUri, node.masterUri, node.jobChan, logger)
logger.Debugf("Done")
sub.pubListChan <- publishers
logger.Debugf("Update publisher list for topic '%s'", sub.topic)
Expand Down
2 changes: 1 addition & 1 deletion ros/subscriber.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func newDefaultSubscriber(topic string, msgType MessageType, callback interface{
return sub
}

func (sub *defaultSubscriber) start(wg *sync.WaitGroup, nodeId string, nodeApiUri string, masterUri string, jobChan chan func(), logger Logger) {
func (sub *defaultSubscriber) start(wg *sync.WaitGroup, nodeId, nodeApiUri, masterUri string, jobChan chan func(), logger Logger) {
logger.Debugf("Subscriber goroutine for %s started.", sub.topic)
wg.Add(1)
defer wg.Done()
Expand Down