Add model:generate attribute datatype validation #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Georift
changed the title
sushantdhiman
approved these changes
Aug 19, 2018
|
Thanks this fixed #222 |
codetriage-readme-bot
pushed a commit
to codetriage-readme-bot/cli
that referenced
this pull request
Jun 5, 2019
Detect all exercises in a workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a small problem today when generating some models, it's pretty easy to mistakenly write something like 'someDate:datetime' as an attribute when it is just 'someDate:date'. The generate command lets it slide and then you end up with some hard to debug .toString() errors by when migrating.
I've added an error condition which halts the generation if any of the attributes contain an invalid DataType.
Also, I noticed that
runCli()intest/support/helpers.jswasn't correctly asserting a non-zero error code so I fixed it by not passing through result.