Skip to content

Conversation

dazhuangc
Copy link
Contributor

@dazhuangc dazhuangc commented Jun 3, 2024

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

#17344

List of Breaking Changes

N/A

@dazhuangc dazhuangc requested a review from a team as a code owner June 3, 2024 07:26
@dazhuangc dazhuangc requested review from ephys and WikiRik June 3, 2024 07:26
@dazhuangc dazhuangc force-pushed the replace-correlated-subquery-with-exists branch 2 times, most recently from ac7bbb6 to e0e6a44 Compare June 4, 2024 09:19
@dazhuangc
Copy link
Contributor Author

dazhuangc commented Jun 4, 2024

db2 latest (Node 18) failed with address already in use, but db2 oldest (Node 18) and db2 oldest/latest (Node 20) succeeded.
https://github.com/sequelize/sequelize/actions/runs/9364519084/job/25778026149
I think the failure is caused by the CI process, not the code change.
Could someone trigger a rerun? I seem to lack permission.

@fzn0x
Copy link
Member

fzn0x commented Jun 4, 2024

I think the CI process is kinda flaky, someone already reruns it :)

@dazhuangc dazhuangc force-pushed the replace-correlated-subquery-with-exists branch 5 times, most recently from f3dcaba to 407ece9 Compare June 7, 2024 01:36
@dazhuangc
Copy link
Contributor Author

dazhuangc commented Jun 7, 2024

@fzn0x Thanks for your comment! Could you review this PR or guide me on what I should do next?

@dazhuangc dazhuangc force-pushed the replace-correlated-subquery-with-exists branch 4 times, most recently from 9df97f2 to 7c856e1 Compare June 13, 2024 01:53
@dazhuangc dazhuangc force-pushed the replace-correlated-subquery-with-exists branch 2 times, most recently from b16645f to 07c795d Compare June 20, 2024 09:53
@dazhuangc dazhuangc force-pushed the replace-correlated-subquery-with-exists branch from 07c795d to f03f233 Compare June 25, 2024 01:34
@dazhuangc dazhuangc force-pushed the replace-correlated-subquery-with-exists branch from f03f233 to f9ea87b Compare January 20, 2025 09:51
@dazhuangc dazhuangc closed this Jan 20, 2025
@dazhuangc dazhuangc reopened this Jan 20, 2025
@dazhuangc
Copy link
Contributor Author

Hi,
Could someone review and merge this PR?
Or I have to skip 40 integration tests for HANA dialect, which lead to execution failure on HANA.

@WikiRik WikiRik enabled auto-merge (squash) January 24, 2025 11:41
auto-merge was automatically disabled January 27, 2025 02:17

Head branch was pushed to by a user without write access

@dazhuangc dazhuangc force-pushed the replace-correlated-subquery-with-exists branch from f9ea87b to 995e6e4 Compare January 27, 2025 02:17
@dazhuangc dazhuangc requested a review from WikiRik January 27, 2025 04:25
@WikiRik WikiRik merged commit 4491353 into sequelize:main Jan 27, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants