Fzn0x/fix optional types v6 #15354
Closed
Fzn0x/fix optional types v6 #15354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(data-types): moment object throwing error * fix: typo * fix: revert with consistent variable naming * test(moment): add moment support test case Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com> Co-authored-by: Sascha Depold <sascha@depold.com>
At that line variable "options" cannot be falsy.
* ci(notifications): notify OpenCollective about releases * ci(release): automatically release update to open-collective * ci(release): update twitter notification code
* meta(deps): update (dev)deps * meta(deps): lock esbuild to 0.14.3 Co-authored-by: Rik Smale <WikiRik@users.noreply.github.com>
* ci(release): dispatch custom event to trigger notifications * Update .github/workflows/ci.yml Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com> Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
…#13823) Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
* docs: add caveat regarding public class fields * docs: update link to class field caveat * feat: improve public class field shadowing detection * refactor: fix lint issue * docs: fix code being incorrectly tagged as invalid Co-authored-by: Guylian Cox <hello@guylian.me> Co-authored-by: Zoé <zoe@ephys.dev>
…13880) Authored-by: sam_rui <sam_rui@trendmicro.com> Co-authored-by: fncolon <fncolon@pm.me>
* fix(model): fix count with grouping typing Fixes #13871 * test: update Model.count(group) typing test Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
* Document `joinTableAttributes` in `belongsToMany` mixin This address #11847 partially at least - I'm not sure where else it should be documented. * Tweak wording a bit * Try to make this a little clearer Co-authored-by: fncolon <fncolon@pm.me>
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com> Co-authored-by: fncolon <fncolon@pm.me>
…od (#13911) Co-authored-by: Zoé <zoe@ephys.dev>
[feature] Drop indices concurrently in Postgres This is a follow up to the feature request. On `removeIndex` it now extends the `options` object to take in a new attribute, `concurrently`, which will ensure that the the SQL statement being run includes `DROP INDEX CONCURRENTLY`... Having this is nice so developers can use the ORM settings when dropping an index, safely, instead of having to write raw SQL. `concurrently` is a supported attribute on addIndex
* fix(model): add stop mysql-8 script * fix(model): fix type for `count` and `findAndCountAll` Co-authored-by: Zoé <zoe@ephys.dev>
Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com> Co-authored-by: Zoé <zoe@ephys.dev>
Co-authored-by: Zoé <zoe@ephys.dev>
* fix(mariadb): do not automatically parse JSON fields * fix(mariadb): do not automatically parse JSON fields * fix(mariadb): passing tests * fix(mariadb): json fields should be able to store strings too * fix(mariadb): comment that MariaDB 10.5.2 already results in JSON format
* feat(oracle): add oracle dialect support (#1) * feat(oracle): add oracle dialect support * fix: addressing review comments (#7) * fix: addressing review comments * fix: minor fixes done (#9) * fix: minor fixes to the review comments * fix: merge from sequelize-v6 * fix: enable newly added unit tests for Oracle dialect * fix: remove dangling comma (#13) * fix: doc gen is fixed * fix: autogenerate the primary constraint name (#14) * fix: autogenerate the primary constraint name * fix: remove trailing comma * fix: make changes to ORADERBY as per v6 sync * fix: move test-unit-oracle above test-unit-all * fix: rename getInsertQueryReturnIntoBinds to populateInsertQueryReturnIntoBinds * fix: reorder parameters for function populateInsertQueryReturnIntoBinds * fix: incorporated review comments (#16) * fix: incorporated review comments * fix: modify string empty check with !
Target patch releases of #14991
* feat(oracle): add oracle dialect support (#1) * feat(oracle): add oracle dialect support * fix: addressing review comments (#7) * fix: addressing review comments * fix: minor fixes done (#9) * fix: minor fixes to the review comments * fix: merge from sequelize-v6 * fix: enable newly added unit tests for Oracle dialect * fix: remove dangling comma (#13) * fix: doc gen is fixed * fix: autogenerate the primary constraint name (#14) * fix: autogenerate the primary constraint name * fix: remove trailing comma * fix: make changes to ORADERBY as per v6 sync * fix: move test-unit-oracle above test-unit-all * fix: rename getInsertQueryReturnIntoBinds to populateInsertQueryReturnIntoBinds * fix: reorder parameters for function populateInsertQueryReturnIntoBinds * fix: incorporated review comments (#16) * fix: incorporated review comments * fix: modify string empty check with ! * feat: support for Oracle DB 18c * Oracle DB version change * added stop-oracle for 18 * fix: changes to DB version query * fix: cleanup * fix: describetable query fix * fix: dbVersion to remove round trip and 18.4 json test fix * fix: removed dbversion * fix: removed comment * fix: testing a feature * fix: testing a feature * fix: testing a feature * fix: testing a feature * fix: testing a feature * fix: testing a feature * fix: test * fix: test * fix: test * fix: test * fix: using semver to coerce version sring * fix: update to instant client latest version for oracle db 21c * fix: update to oracledb version in package.json * fix: update lockfile * fix: remove duplicate privileges.sql and wait-until-healthy.sh * fix: changes to start-oracle alias * fix: changes to start-oracle alias * fix: changes to start-oracle alias Co-authored-by: Sudarshan Soma <48428602+sudarshan12s@users.noreply.github.com>
…15065) * add Model.BelongsToMany.through.paranoid option in documentation * add paranoid option for Model.BelongsToMany.through * Update model.js add paranoid option for Model.BelongsToMany.through * add paranoid option in Model.BelongsToMany.through sync description paranoid option with belongs-to-many.d.ts
…support vars after ->> operator, treat lowercase e as valid e-string prefix (#15139) * fix: don't treat \ as escape in standard strings, support E-strings We also support support vars after ->> operator now. Backport of #14700 * fix(postgres): treat lowercase e as valid e-string prefix * fix: nullish coalescence * fix: cleanup * fix: spaces * fix: postgres tests * fix: add third param to trigger right behavior * fix: tests * fix: formatting * fix: remove unused code * meta: more formatting * meta: more formatting * fix: merge test cases
* meta: swap Slack links * meta: retest
* fix: remove options.model overwrite on bulkUpdate (#15231) * fix: remove options.model overwrite on bulkUpdate * fix: fix typo in test * fix: make test simpler Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com> Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com> (cherry picked from commit c620469) * fix: adapt test to v6
* fix(postgres): invalidate connection after client-side timeout Merge ff43e8d from main: The `query_timeout` feature of the `pg` package helps handle stuck TCP connections more quickly and gracefully by implementing a client-side timeout: brianc/node-postgres#1713 Sequelize started passing this dialect-specific option through to `pg` here: #13258 I believe we also want to invalidate the connection when a client-side timeout occurs. We shouldn't try to reuse the stuck connection because...it's stuck. This PR updates the error handling code so that the connection is invalidated if the error matches the one thrown from here: https://github.com/brianc/node-postgres/blob/5538df6b446f4b4f921947b460fe38acb897e579/packages/pg/lib/client.js#L529 * fix syntax error * fix another syntax error * fix import
fzn0x
added
the
type: typescript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please move to #15356
Can't change the base branch here 😄