Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(postgres, sqlite): map conflictFields to column names in Model.upsert #17211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(postgres, sqlite): map conflictFields to column names in Model.upsert #17211

wants to merge 1 commit into from

Conversation

muraliprajapati
Copy link

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

Closes #14150

An old PR (#14199) fixing the linked issue became stale and was closed. @WikiRik suggested creating a new PR.

List of Breaking Changes

None

@muraliprajapati muraliprajapati requested a review from a team as a code owner March 26, 2024 18:42
@muraliprajapati
Copy link
Author

@ephys @WikiRik Please review this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys Awaiting requested review from ephys ephys is a code owner automatically assigned from sequelize/code-reviewers

@WikiRik WikiRik Awaiting requested review from WikiRik WikiRik is a code owner automatically assigned from sequelize/code-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL field name used instead of property name in conflictFields
1 participant
@muraliprajapati