test lower node versions properly #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous CI setup wasn't actually running, it was throwing an uncaught rejection and somehow exiting with code 0 anyway
getting vitest to work on node 12 was miles away from working, so moving the node version tests to the
test_tgzjob, which is a simpler test that ensures the basics work.Also adds some small fixes to the library itself to get it closer to working, but the
globdependency is the sticking point for node 12. 14, 16, 18 are now fine.globdependency will be replaced in #660If getting node 12 to work proves impossible, we might need to just go to a v4 release but hopefully not.