Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect old docs to new docs #100

Closed
papb opened this issue Jul 22, 2019 · 14 comments · Fixed by #123
Closed

Redirect old docs to new docs #100

papb opened this issue Jul 22, 2019 · 14 comments · Fixed by #123
Assignees

Comments

@papb
Copy link
Member

papb commented Jul 22, 2019

I think we should add a 301 REDIRECT (Moved Permanently) to the old v3 docs and the "old" v5 docs pointing to the new hosts instead (here and here respectively).

This would solve sequelize/sequelize#10610 as well

@sushantdhiman

@sushantdhiman
Copy link

We can redirect old v5, not access to old v3 docs

@sushantdhiman sushantdhiman self-assigned this Jul 25, 2019
@papb
Copy link
Member Author

papb commented Jul 25, 2019

@sushantdhiman Who has access to the old v3 docs?

@sushantdhiman
Copy link

Old v5 docs redirected to new ones

@papb
Copy link
Member Author

papb commented Jul 26, 2019

@sushantdhiman Are the old v3 docs (here and here) completely inaccessible? Isn't there anything we can do about them?

@sushantdhiman
Copy link

image

@janmeier / @sdepold

@sushantdhiman
Copy link

By the way https://sequelize.readthedocs.io/en/v3/ will get redirected to https://sequelize.org/v3

@papb
Copy link
Member Author

papb commented Jul 26, 2019

@sushantdhiman Actually apparently only the main page follows the redirect.

Entering one specific page such as http://docs.sequelizejs.com/manual/associations.html does not redirect...

Also will these redirects affect SEO?

@joequincy
Copy link

It looks like this is in progress... visiting a page like https://docs.sequelizejs.com/en/latest/docs/associations/ (Google points here) appropriately redirects to https://sequelize.org/master/manual/associations.html

However, the current cert served for https://docs.sequelizejs.com/* is assigned for *.surge.sh, which causes browser warnings in at least Chrome and Firefox, e.g.
SSL_ERROR_BAD_CERT_DOMAIN warning shown in Firefox

Additional cert screenshots for troubleshooting

Certificate Heirarchy shown in Firefox
Certificate Viewer details shown in Firefox

@papb
Copy link
Member Author

papb commented Sep 24, 2019

@joequincy Indeed I was able to reproduce this, @sushantdhiman can you take a look?

@sushantdhiman
Copy link

We can't fix docs.sequelizejs.com, that's why I got new domain sequelize.org

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

This issue has been automatically marked as stale because it has been open for 7 days without activity. It will be closed if no further activity occurs. If this is still an issue, just leave a comment or remove the "stale" label. 🙂

@ephys ephys transferred this issue from sequelize/sequelize Apr 16, 2022
@sdepold
Copy link
Member

sdepold commented Apr 21, 2022

I guess this ticket is done @ephys ?

sdepold added a commit that referenced this issue Apr 21, 2022
sdepold added a commit that referenced this issue Apr 21, 2022
@sdepold
Copy link
Member

sdepold commented Apr 21, 2022

So this works now https://sequelize.readthedocs.io/en/v3/.

@ephys
Copy link
Member

ephys commented Apr 21, 2022

I guess this ticket is done @ephys ?

Yep! Looks good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants