Update model-basics.md #426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide additional comment on usage of composite index in model definition
Add notice of alternative
ephys
requested changes
Mar 14, 2023
| @@ -425,7 +425,9 @@ Foo.init({ | |||
|
|
|||
| // Creating two objects with the same value will throw an error. The unique property can be either a | |||
| // boolean, or a string. If you provide the same string for multiple columns, they will form a | |||
| // composite unique key. | |||
| // composite unique key. Note that this does not work with neither Sequelize.define() nor | |||
| // QueryInterface.createTable(). Details here: https://github.com/sequelize/sequelize/issues/14039 | |||
There was a problem hiding this comment.
sequelize.define() is a wrapper around Model.init() so this option does work with define
Separately, I don't think it's the role of the model documentation to explain how createTable works. That's a concern for a separate documentation dedicated to queryInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide additional comment on usage of composite index in model definition