Fix #982 Enable developers to customize the "/slack/install" webpage content #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## issue-977-slack-install-flag #1 +/- ##
===============================================================
Coverage ? 70.70%
===============================================================
Files ? 13
Lines ? 1222
Branches ? 363
===============================================================
Hits ? 864
Misses ? 286
Partials ? 72 Continue to review full report at Codecov.
|
…r to ExpressReceiver (slackapi#1084)
…iver: Receiver arguments in App constructor (slackapi#1077) * Fix slackapi#1068 Throw an error if both socketMode: boolean and receiver: Receiver arguments in App constructor * Update src/App.ts
…/install" (slackapi#1079) * Fix slackapi#977 Add a way to turn off web page rendering for "/slack/install" * Remove package-lock.json from the example app * Apply suggestions from code review Co-authored-by: Fil Maj <maj.fil@gmail.com> * Add bolt to dependencies * Comment out the new flag in the example app * Rename directInstallUrlEnabled to directInstall * Apply suggestions from code review Co-authored-by: Sarah Jiang <srajiang@gmail.com> Co-authored-by: Fil Maj <maj.fil@gmail.com> Co-authored-by: Sarah Jiang <srajiang@gmail.com>
seratch
force-pushed
the
issue-982-install-page-renderer
branch
from
4bbbd19
to
b5938e6
Compare
…for invoking the installRedirectHandler
Update code to fix TS v.4.4 compiler errors
…oving fully to eslint from tslint. All of these changes are courtesy of @aoberoi and the work they put into slackapi#669 🙇
…d using snake_case
…tead. Dedupe some copy-pasted test helpers from AwsReceiver spec. Move a linter ignore directive from tslint to eslint.
…naming conventions.
… = operator, and prefix for other operators to be at the end of the line.
…irectories to import submodules from.
…s the use of short-circuit logical operators (|| and &&).
Allow use of "as Type" syntax for type assertions in test code. Dont force symbol descriptors in test code
…he accessibility of constructors for various classes.
…webpage content
seratch
force-pushed
the
issue-982-install-page-renderer
branch
from
a59e189
to
ac6b5bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes slackapi#982 by adding a new function argument to customize the HTML content renderer for
/slack/installURL.Requirements (place an
xin each[ ])