Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatter methods should return io::Error instead of serde_json::Error #274

Closed
dtolnay opened this issue Mar 6, 2017 · 2 comments
Closed

Formatter methods should return io::Error instead of serde_json::Error #274

dtolnay opened this issue Mar 6, 2017 · 2 comments
Labels
breaking change
Milestone
v1.0

Comments

@dtolnay
Copy link
Member

dtolnay commented Mar 6, 2017

See #267 (comment).

Note that if the Formatter methods produced io::Error errors, or at least if the portion that handles strings did, we wouldn't need to implement fmt::Write and store a serde_json::Error out of band, instead we could use write! directly and use the returned io::Error.
@dtolnay
Copy link
Member Author

dtolnay commented Mar 13, 2017

There should be no reason for a Formatter to fail other than IO.

@dtolnay dtolnay added this to the v1.0 milestone Apr 11, 2017
@dtolnay dtolnay mentioned this issue Apr 11, 2017
Merged
@dtolnay
Copy link
Member Author

dtolnay commented Apr 11, 2017

Fixed in #299.

@dtolnay dtolnay closed this as completed Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Milestone
v1.0
Development

No branches or pull requests
1 participant
@dtolnay