Redefine Serializer::collect_str #267
Conversation
|
Related to serde-rs/serde#789, do not merge yet. |
json/src/ser.rs
Outdated
| { | ||
| fn write_str(&mut self, s: &str) -> fmt::Result { | ||
| assert!(self.error.is_none()); | ||
| match self.formatter.write_string_fragment(&mut self.writer, s.as_bytes()) { |
There was a problem hiding this comment.
The write_string_fragment method dumps bytes directly into the output. Instead you need to factor out the middle part of format_escaped_str and use that here to properly escape any special characters.
There was a problem hiding this comment.
Made write_string_fragment take a &str and contain the whole loop from the function format_escaped_str.
nox
force-pushed
the
display
branch
2 times, most recently
from
540a382
to
46ea736
Compare
|
I also added a commit to optimise serialising a single |
|
This is a breaking change for rq which overrides write_string_fragment: rq/value/json.rs Please do not make any changes to Formatter in this PR. The loop for calling write_string_fragment / write_char_escape should live outside of Formatter. I filed #268 to follow up on the argument type in the next major release. |
json/src/ser.rs
Outdated
| let mut buf = [0; 4]; | ||
| write!(&mut buf[..], "{}", value).unwrap(); | ||
| let str = unsafe { str::from_utf8_unchecked(&buf[0..value.len_utf8()]) }; | ||
| format_escaped_str(wr, formatter, str) |
There was a problem hiding this comment.
Please do not call any variables str. GitHub shows it as a keyword and makes it look like a bug.
json/src/ser.rs
Outdated
| use std::io::Write; | ||
| let mut buf = [0; 4]; | ||
| write!(&mut buf[..], "{}", value).unwrap(); | ||
| let str = unsafe { str::from_utf8_unchecked(&buf[0..value.len_utf8()]) }; |
There was a problem hiding this comment.
Add a brief justification of why this is safe along with a link to https://github.com/serde-rs/json/issues/270.
This allows us to format_args!() and friends while avoiding String allocations when serialising to JSON.
|
Note that if the |
No description provided.