Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize serde_json::from_reader #1007

Closed
wants to merge 7 commits into from
Closed

Optimize serde_json::from_reader #1007

wants to merge 7 commits into from

Commits on Apr 1, 2023

  1. Buffer internally in IoRead

    @tgnottingham
    tgnottingham committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    4cc38b2 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2023

  1. Replace BufReader with our own buffer in IoRead

    @tgnottingham
    tgnottingham committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    652c97c View commit details
    Browse the repository at this point in the history

  2. Avoid updating position on each byte read in IoRead

    @tgnottingham
    tgnottingham committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    5b7385f View commit details
    Browse the repository at this point in the history

  3. Have read::error take Position instead of Read

    @tgnottingham
    tgnottingham committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    c201ba5 View commit details
    Browse the repository at this point in the history

  4. Avoid copying into scratch space when possible

    @tgnottingham
    tgnottingham committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    a16902c View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Use Position::update in more places

    @tgnottingham
    tgnottingham committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    77c1a79 View commit details
    Browse the repository at this point in the history

  2. Clarify comment

    @tgnottingham
    tgnottingham committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    7299551 View commit details
    Browse the repository at this point in the history