get_concurrent values

[KM8Oz]

/// Similar to `get` method but fast to get deep json Value
    /// ```
    /// # use serde_json::json;
    ///
    /// let object = json!({ "A": { "B": { "C": "foo" } } }); // true
    ///
    /// assert_eq!(*array.get_concurrent("A.B.C").unwrap(), json!("foo")); // true
    /// assert_eq!(*array.get_concurrent("A.B.C.D").unwrap(), json!("foo")); // true also
    /// ```

    pub fn get_concurrent(&self, list: &str) -> Option<Value> {
        let rest: Value = Value::default();
        for item in list.split(".").into_iter() {
            let rest = match self.0.get(item) {
                Some(m) => Some(m),
                None => Some(&self.0),
            };
        }
        Some(rest)
    }

[kangalio]

I suspect this won't be merged as-is. It is a rather opinionated feature for such a fundamental crate.

Also, it's not ready needed: object["A"]["B"]["C"] works.

[KM8Oz]

I made some changes on it so it will fit my needs. Thanks overall

…

On Tue, May 23, 2023, 19:28 kangalio ***@***.***> wrote: I suspect this won't be merged as-is. It is a rather opinionated feature for such a fundamental crate. Also, it's not ready needed: object["A"]["B"]["C"] works. — Reply to this email directly, view it on GitHub <#930 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKPIGZMNNOIJH3MFGYTD53XHT6WJANCNFSM6AAAAAAQJ4LUFM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[dtolnay]

This does not compile.

error: expected a trait, found type
   --> src/value/mod.rs:317:30
    |
317 |     pub fn get_concurrent<I: &str>(&self, pattern: I) -> Option<Value> {
    |                              ^^^^

[dtolnay]

This does not compile.

error[E0425]: cannot find value `list` in this scope
   --> src/value/mod.rs:319:21
    |
319 |         for item in list.split(".").into_iter() {
    |                     ^^^^ not found in this scope

[dtolnay]

This does not compile.

error[E0609]: no field `0` on type `&Value`
   --> src/value/mod.rs:320:35
    |
320 |             let rest = match self.0.get(item) {
    |                                   ^ unknown field

[dtolnay]

This function would always return Some(Value::Null), which does not seem useful.

[dtolnay]

This looks like an ad-hoc redesign of JSON Pointer (RFC 6901). I would prefer not to include this in serde_Json.