Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move serde into it's own organization #68

Closed
erickt opened this issue Apr 26, 2015 · 16 comments
Closed

Move serde into it's own organization #68

erickt opened this issue Apr 26, 2015 · 16 comments

Comments

@erickt
Copy link
Member

erickt commented Apr 26, 2015

@Byron / @oli-obk / @hugoduncan / @tomprogrammer / @kvark: FYI, if you haven't noticed, serde now has a new github organization. I want to be a little more formal about reviewing my patches with the rest of the serde community.

@Byron
Copy link
Contributor

Byron commented Apr 26, 2015

A great move ! This will definitely give it (even) more velocity !
Thank you for taking care !

@frewsxcv
Copy link
Contributor

This can be closed, right?

@erickt
Copy link
Member Author

erickt commented May 19, 2015

Yep!

@erickt erickt closed this as completed May 19, 2015
@oli-obk
Copy link
Member

oli-obk commented May 19, 2015

do you want serde (de-)serializer-repos in that orga or do you prefer the devs to put them in their own repos?

@erickt
Copy link
Member Author

erickt commented May 19, 2015

@oli-obk: I'd be happy to have them in serde.rs. Want one for xml? What would you like it called?

@Byron: want one for yaml?

@oli-obk
Copy link
Member

oli-obk commented May 19, 2015

Just xml? Since it'll already be inside the serde-rs orga it doesn't need any annotations like rust or serde.

@Byron
Copy link
Contributor

Byron commented May 26, 2015

@erickt Sorry for the late reply. It seems there is a repo for yaml already. Right now I don't know how you see the separation to be done,but I guess I can just look at the json implementation once it is there. In the meanwhile, I will keep working in my fork and communicate through the PR, until there is something usable.

@oli-obk
Copy link
Member

oli-obk commented May 26, 2015

@Byron: the xml-deserialization is already working as its own repo. Maybe that'll help set it up for yaml.

@Byron
Copy link
Contributor

Byron commented May 26, 2015

@oli-obk Thank you, I will do that ! I'd still have a lot of questions about how collaboration is supposed to work. Maybe a guide exists somewhere and I didn't find it. For reasons of lazyness, I'd just push to serde-rs/yaml directly, without setting up a PR to allow code-reviews. The latter, however, would be good to have, and I would love to get other eyes on the code at least once certain milestones are met. While writing this, I changed my mind and now believe a PR based workflow would be the way to go ... so let's do it that way :).

@oli-obk
Copy link
Member

oli-obk commented May 26, 2015

technically we should set up homu to get the r+ abilities

@oli-obk
Copy link
Member

oli-obk commented May 26, 2015

i am still pushing directly, as it's so early in development, but if you think reviews are better, I can start doing PRs

@Byron
Copy link
Contributor

Byron commented May 26, 2015

I am not sure who will have time for reviews anyway, however, I just want to get used to that workflow, and if in doubt, will just merge my own PRs.

@oli-obk
Copy link
Member

oli-obk commented May 26, 2015

we can do mutual reviewing. Not sure how I can set github up to get notifications about PRs though

@frewsxcv
Copy link
Contributor

Could just get added as members (not necessarily owners) to a team in the organization and whenever a review needs to happen, just ping the team

@Byron
Copy link
Contributor

Byron commented May 26, 2015

I agree, this could just work using the @ syntax to reach out to individuals.

@oli-obk
Copy link
Member

oli-obk commented May 26, 2015

I put myself on the "watch" thingy next to "fork" and "star" for yaml, maybe it'll work :)

rubdos pushed a commit to rubdos/serde that referenced this issue Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants