Allow larger preallocated capacity for smaller elements #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
reviewed
Jul 10, 2023
| pub fn cautious<Element>(hint: Option<usize>) -> usize { | ||
| const MAX_PREALLOC_BYTES: usize = 1024 * 1024; | ||
|
|
||
| if mem::size_of::<Element>() == 0 { |
There was a problem hiding this comment.
It would be good to cache the result of mem::size_of::<Element>() and reuse it at line 19 below
There was a problem hiding this comment.
This is the const function since 1.24 so it will be computed by the compiler
jonasbb
added a commit
to jonasbb/serde_with
that referenced
this pull request
Jul 31, 2023
Upstream serde has a new implementation of the cautious size hint function, which takes into consideration the size of the elements. Use the same implementation in serde_with. serde-rs/serde#2495
bors bot
added a commit
to jonasbb/serde_with
that referenced
this pull request
Jul 31, 2023
629: Sync the size_hint changes from serde r=jonasbb a=jonasbb Upstream serde has a new implementation of the cautious size hint function, which takes into consideration the size of the elements. Use the same implementation in serde_with. serde-rs/serde#2495 bors r+ Co-authored-by: Jonas Bushart <jonas@bushart.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2494.