Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "space case" & "SCREAMING SPACE CASE" rename rules #2657

Closed
wants to merge 4 commits into from
Closed

Add "space case" & "SCREAMING SPACE CASE" rename rules #2657

wants to merge 4 commits into from

Conversation

xenoliss
Copy link

@xenoliss xenoliss commented Nov 24, 2023 •
edited
Loading

Add a two new RenameRule variants to handle "space case" and "SCREAMING SPACE CASE".

@xenoliss xenoliss mentioned this pull request Nov 24, 2023
Merged
@xenoliss xenoliss changed the title Add SERDE SPACE CASE rename rule Add SCREAMING SPACE CASE rename rule Nov 24, 2023
@xenoliss xenoliss changed the title Add SCREAMING SPACE CASE rename rule Add space case & SCREAMING SPACE CASE rename rules Nov 24, 2023
@xenoliss xenoliss changed the title Add space case & SCREAMING SPACE CASE rename rules Add "space case" & "SCREAMING SPACE CASE" rename rules Nov 24, 2023
dtolnay
dtolnay reviewed Nov 24, 2023
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I think these are both in the same category as #1724; I would prefer not to build this into serde_derive.

@dtolnay dtolnay closed this Nov 24, 2023
@jonasbb jonasbb mentioned this pull request Nov 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xenoliss @dtolnay