Updating of report generation engine to wait for started threads, and close all opened streams #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YamStranger
added a commit
that referenced
this pull request
Feb 3, 2016
Updating of report generation engine to wait for started threads, and close all opened streams
…eam and readers closing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of this PR
Updates way of waiting generated reports. Also code updated to use java-core enums instead of same from google, and updated way of closing opened streams. Updated code that prints to System.err to logging with error level. Updated default config of cores witch are used during report generation to be dependent on cpu configuration.
Intended effect
Tests should became stable and do not fail "time to time" because of abscond reports/screenshots
How should this be manually tested?
Behaving should not change
Side effects
N/A
Documentation
N/A
Relevant tickets
#173
Screenshots (if appropriate)
N/A