Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap to FxHash instead of default Hasher #2084

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Swap to FxHash instead of default Hasher #2084

merged 2 commits into from
Aug 9, 2022

Conversation

GnomedDev
Copy link
Member

@GnomedDev GnomedDev commented Aug 7, 2022 •
edited
Loading

We don't need to care about HashDOS as the IDs are controlled by discord, not the user, so we can swap to a cheaper Hasher to improve cache performance. A debate is to be had between AHash and FxHash however:

  1. We are simply hashing IDs (u64s), and would be using nohash_hasher if not for distribution
  2. Benchmarks could take a while to do, and this is simple performance improvement now instead of waiting a while for cache statistics to be added, which is when AHash vs FxHash debates could be settled.

@github-actions github-actions bot added the cache Related to the `cache`-feature. label Aug 7, 2022
@arqunis arqunis added the enhancement An improvement to Serenity. label Aug 9, 2022
@arqunis arqunis merged commit 0453b37 into serenity-rs:next Aug 9, 2022
arqunis pushed a commit to arqunis/serenity that referenced this pull request Aug 21, 2022
@GnomedDev @arqunis
Swap to FxHash instead of default hasher (serenity-rs#2084)
9a1f299
arqunis pushed a commit to arqunis/serenity that referenced this pull request Sep 2, 2022
@GnomedDev @arqunis
Swap to FxHash instead of default hasher (serenity-rs#2084)
b0162dc
kangalio pushed a commit to kangalio/serenity that referenced this pull request Sep 11, 2022
@GnomedDev @kangalio
Swap to FxHash instead of default hasher (serenity-rs#2084)
9970f4c
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 1, 2022
@GnomedDev @mkrasnitski
Swap to FxHash instead of default hasher (serenity-rs#2084)
1ddd9f1
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Nov 7, 2022
@GnomedDev @mkrasnitski
Swap to FxHash instead of default hasher (serenity-rs#2084)
69b42fe
arqunis pushed a commit to arqunis/serenity that referenced this pull request Nov 13, 2022
@GnomedDev @arqunis
Swap to FxHash instead of default hasher (serenity-rs#2084)
e9b9b23
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 28, 2023
@GnomedDev @mkrasnitski
Swap to FxHash instead of default hasher (serenity-rs#2084)
5037822
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 18, 2023
@GnomedDev @mkrasnitski
Swap to FxHash instead of default hasher (serenity-rs#2084)
9ecee82
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 30, 2023
@GnomedDev @mkrasnitski
Swap to FxHash instead of default hasher (serenity-rs#2084)
878786b
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@GnomedDev @mkrasnitski
Swap to FxHash instead of default hasher (serenity-rs#2084)
b0921a5
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
@GnomedDev @mkrasnitski
Swap to FxHash instead of default hasher (serenity-rs#2084)
cfdf0f9
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
@GnomedDev @mkrasnitski
Swap to FxHash instead of default hasher (serenity-rs#2084)
c2787ec
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@GnomedDev @arqunis
Swap to FxHash instead of default hasher (serenity-rs#2084)
ff99476
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@GnomedDev @arqunis
Swap to FxHash instead of default hasher (serenity-rs#2084)
f05ad01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
cache Related to the `cache`-feature. enhancement An improvement to Serenity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis