Replace usage of CacheAndHttp in dispatch with Context
#2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkrasnitski
force-pushed
the
cleanup_dispatch
branch
from
5c85a3d
to
30c7ee7
Compare
mkrasnitski
force-pushed
the
cleanup_dispatch
branch
from
30c7ee7
to
4939399
Compare
|
Ah yeah, sorry. The dispatch function itself didn't change much, I just removed the calls to |
kangalio
approved these changes
Oct 3, 2022
Merged
arqunis
approved these changes
Oct 3, 2022
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Nov 7, 2022
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Nov 13, 2022
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 28, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
May 18, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
May 30, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 17, 2023
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of an effort to split #2118 up to address some of the concerns raised there. This PR changes dispatch such that it passes a context around instead of constructing one over and over, simplifying method signatures and reducing the number of clones (the clones themselves were cheap anyways because it was just Arc cloning, which means just incrementing a refcount).
The whole
DispatchEvent::update_cachething is still really ugly, as its only used in the absence of an non-raw event handler. Ideally I'd like to get rid of it somehow.