Actually include all types in model::prelude and make inline #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other top-level model modules don't have such teeny tiny sub modules
The module says "The model prelude re-exports all types in the model sub-modules." which wasn't actually true but now it is. In addition, I added `#[doc(inline)]` so you can see every model type on one page. This is convenient e.g. to copy paste them into a program and create a ranking of model types by size
arqunis
approved these changes
Oct 3, 2022
arqunis
added
enhancement
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Nov 7, 2022
arqunis
pushed a commit
that referenced
this pull request
Nov 13, 2022
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 28, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 18, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 30, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 17, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module says "The model prelude re-exports all types in the model sub-modules." which wasn't actually true but now it is. In addition, I added
#[doc(inline)]so you can see every model type on one page. This is convenient e.g. to copy paste them into a program and create a ranking of model types by size