Add CacheSettings::{time_to_live, cache_guilds, cache_channels, cache_users} #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cache
Forgot that Rust's stupid "you're not allowed to use struct update syntax for #[non_exhaustive] structs haha cope" role doesn't apply within the same crate
arqunis
approved these changes
Oct 21, 2022
arqunis
added
enhancement
Closed
Closed
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Nov 7, 2022
…e_users}` (serenity-rs#2210) The idea is that even users on resource contrained devices can enable cache feature, but just disable all the individual caching flags. What remains is the cached fixed-size data: `CachedShardData` and more importantly `CurrentUser`.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Nov 13, 2022
…e_users}` (serenity-rs#2210) The idea is that even users on resource contrained devices can enable cache feature, but just disable all the individual caching flags. What remains is the cached fixed-size data: `CachedShardData` and more importantly `CurrentUser`.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 28, 2023
…e_users}` (serenity-rs#2210) The idea is that even users on resource contrained devices can enable cache feature, but just disable all the individual caching flags. What remains is the cached fixed-size data: `CachedShardData` and more importantly `CurrentUser`.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 18, 2023
…e_users}` (serenity-rs#2210) The idea is that even users on resource contrained devices can enable cache feature, but just disable all the individual caching flags. What remains is the cached fixed-size data: `CachedShardData` and more importantly `CurrentUser`.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 30, 2023
…e_users}` (serenity-rs#2210) The idea is that even users on resource contrained devices can enable cache feature, but just disable all the individual caching flags. What remains is the cached fixed-size data: `CachedShardData` and more importantly `CurrentUser`.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
…e_users}` (serenity-rs#2210) The idea is that even users on resource contrained devices can enable cache feature, but just disable all the individual caching flags. What remains is the cached fixed-size data: `CachedShardData` and more importantly `CurrentUser`.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 17, 2023
…e_users}` (serenity-rs#2210) The idea is that even users on resource contrained devices can enable cache feature, but just disable all the individual caching flags. What remains is the cached fixed-size data: `CachedShardData` and more importantly `CurrentUser`.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
…e_users}` (serenity-rs#2210) The idea is that even users on resource contrained devices can enable cache feature, but just disable all the individual caching flags. What remains is the cached fixed-size data: `CachedShardData` and more importantly `CurrentUser`.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
…e_users}` (serenity-rs#2210) The idea is that even users on resource contrained devices can enable cache feature, but just disable all the individual caching flags. What remains is the cached fixed-size data: `CachedShardData` and more importantly `CurrentUser`.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
…e_users}` (serenity-rs#2210) The idea is that even users on resource contrained devices can enable cache feature, but just disable all the individual caching flags. What remains is the cached fixed-size data: `CachedShardData` and more importantly `CurrentUser`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that even users on resource contrained devices can enable cache feature, but just disable all the individual caching flags. What remains is the cached fixed-size data: CachedShardData and more importantly CurrentUser.
This aims to fix #1953 and supersede #2138 by hopefully making it redundant to disable cache