Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce extra clones in the http module #2219

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Reduce extra clones in the http module #2219

merged 3 commits into from
Oct 21, 2022

Conversation

mkrasnitski
Copy link
Collaborator

This is a revamp of #2071 based on top of the new changes to next, as the old PR had gotten stale. We pass around owned data to reduce clones. Also, removing any last uses of String in RouteInfo lets us mark it Copy, improving ergonomics.

@github-actions github-actions bot added examples Related to Serenity's examples. http Related to the `http` module. model Related to the `model` module. labels Oct 17, 2022
evelynharthbrooke
evelynharthbrooke approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@evelynharthbrooke evelynharthbrooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me 👍🏼

@arqunis arqunis added the enhancement An improvement to Serenity. label Oct 21, 2022
@arqunis arqunis merged commit e8df852 into serenity-rs:next Oct 21, 2022
@mkrasnitski mkrasnitski deleted the cleanup-http branch October 24, 2022 02:03
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Nov 7, 2022
@mkrasnitski
Reduce extra clones in the http module (serenity-rs#2219)
e2f34fe
arqunis pushed a commit to arqunis/serenity that referenced this pull request Nov 13, 2022
@mkrasnitski @arqunis
Reduce extra clones in the http module (serenity-rs#2219)
ee4ac84
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Feb 28, 2023
@mkrasnitski
Reduce extra clones in the http module (serenity-rs#2219)
5836381
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request May 18, 2023
@mkrasnitski
Reduce extra clones in the http module (serenity-rs#2219)
bc1fcbe
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request May 30, 2023
@mkrasnitski
Reduce extra clones in the http module (serenity-rs#2219)
d4e2730
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@mkrasnitski
Reduce extra clones in the http module (serenity-rs#2219)
8ff53fc
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
@mkrasnitski
Reduce extra clones in the http module (serenity-rs#2219)
12f3d10
mkrasnitski added a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
@mkrasnitski
Reduce extra clones in the http module (serenity-rs#2219)
a570e48
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@mkrasnitski @arqunis
Reduce extra clones in the http module (serenity-rs#2219)
58647e5
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@mkrasnitski @arqunis
Reduce extra clones in the http module (serenity-rs#2219)
3620f9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

@evelynharthbrooke evelynharthbrooke evelynharthbrooke approved these changes

Assignees
No one assigned
Labels
enhancement An improvement to Serenity. examples Related to Serenity's examples. http Related to the `http` module. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkrasnitski @evelynharthbrooke @arqunis