Upgrade dependencies #2353
Merged
Upgrade dependencies #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
builder
arqunis
approved these changes
Mar 5, 2023
arqunis
added
breaking change
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
May 18, 2023
Update Serenity's dependencies to the latest major versions. This requires a breaking change to the signature of `serenity::json::from_str`. This is to ensure the soundness of calling `simd_json::from_str`, which is unsafe, in that it might modify the underlying string such that it no longer contains valid UTF-8. So, if our wrapper function takes ownership of the buffer, it will be dropped at the end of the function, guaranteeing that invalid UTF-8 cannot be used afterward.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
May 30, 2023
Update Serenity's dependencies to the latest major versions. This requires a breaking change to the signature of `serenity::json::from_str`. This is to ensure the soundness of calling `simd_json::from_str`, which is unsafe, in that it might modify the underlying string such that it no longer contains valid UTF-8. So, if our wrapper function takes ownership of the buffer, it will be dropped at the end of the function, guaranteeing that invalid UTF-8 cannot be used afterward.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
Update Serenity's dependencies to the latest major versions. This requires a breaking change to the signature of `serenity::json::from_str`. This is to ensure the soundness of calling `simd_json::from_str`, which is unsafe, in that it might modify the underlying string such that it no longer contains valid UTF-8. So, if our wrapper function takes ownership of the buffer, it will be dropped at the end of the function, guaranteeing that invalid UTF-8 cannot be used afterward.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 17, 2023
Update Serenity's dependencies to the latest major versions. This requires a breaking change to the signature of `serenity::json::from_str`. This is to ensure the soundness of calling `simd_json::from_str`, which is unsafe, in that it might modify the underlying string such that it no longer contains valid UTF-8. So, if our wrapper function takes ownership of the buffer, it will be dropped at the end of the function, guaranteeing that invalid UTF-8 cannot be used afterward.
mkrasnitski
added a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
Update Serenity's dependencies to the latest major versions. This requires a breaking change to the signature of `serenity::json::from_str`. This is to ensure the soundness of calling `simd_json::from_str`, which is unsafe, in that it might modify the underlying string such that it no longer contains valid UTF-8. So, if our wrapper function takes ownership of the buffer, it will be dropped at the end of the function, guaranteeing that invalid UTF-8 cannot be used afterward.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
Update Serenity's dependencies to the latest major versions. This requires a breaking change to the signature of `serenity::json::from_str`. This is to ensure the soundness of calling `simd_json::from_str`, which is unsafe, in that it might modify the underlying string such that it no longer contains valid UTF-8. So, if our wrapper function takes ownership of the buffer, it will be dropped at the end of the function, guaranteeing that invalid UTF-8 cannot be used afterward.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
Update Serenity's dependencies to the latest major versions. This requires a breaking change to the signature of `serenity::json::from_str`. This is to ensure the soundness of calling `simd_json::from_str`, which is unsafe, in that it might modify the underlying string such that it no longer contains valid UTF-8. So, if our wrapper function takes ownership of the buffer, it will be dropped at the end of the function, guaranteeing that invalid UTF-8 cannot be used afterward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update serenity's dependencies to the latest major versions. This requires a breaking change to the signature of
serenity::json::from_str. This is to ensure the soundness of callingsimd_json::from_str, which is unsafe, in that it might modify the underlying string such that it no longer contains valid UTF-8. So, if our wrapper function takes ownership of the buffer, it will be dropped at the end of the function, guaranteeing that invalid UTF-8 cannot be used afterward.