Prevent double slashes with HTTP proxy #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes serenity-rs#2322 Probably wouldn't have caused because double slashes are treated by HTTP servers as single slashes in my experience. After a bit of back and forth I opted not to use reqwest methods. Parsing the given proxy in HttpBuilder into an Url directly means the builder method returns Result (or panics) which is both ugly. Also, Url's methods yield the scheme and domain both as &str, so we would still just have a string in the internal proxy field instead of a type-safe value. So I kept the current simple solution that gets the job done and just added the fix
arqunis
approved these changes
Apr 8, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 18, 2023
Fixes serenity-rs#2322 Probably wouldn't have caused because double slashes are treated by HTTP servers as single slashes in my experience. After a bit of back and forth I opted not to use reqwest methods. Parsing the given proxy in `HttpBuilder` into an `Url` directly means the builder method returns `Result` (or panics) which is both ugly. Also, `Url`'s methods yield the scheme and domain both as `&str`, so we would still just have a string in the internal proxy field instead of a type-safe value. So I kept the current simple solution that gets the job done and just added the fix.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 30, 2023
Fixes serenity-rs#2322 Probably wouldn't have caused because double slashes are treated by HTTP servers as single slashes in my experience. After a bit of back and forth I opted not to use reqwest methods. Parsing the given proxy in `HttpBuilder` into an `Url` directly means the builder method returns `Result` (or panics) which is both ugly. Also, `Url`'s methods yield the scheme and domain both as `&str`, so we would still just have a string in the internal proxy field instead of a type-safe value. So I kept the current simple solution that gets the job done and just added the fix.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
Fixes serenity-rs#2322 Probably wouldn't have caused because double slashes are treated by HTTP servers as single slashes in my experience. After a bit of back and forth I opted not to use reqwest methods. Parsing the given proxy in `HttpBuilder` into an `Url` directly means the builder method returns `Result` (or panics) which is both ugly. Also, `Url`'s methods yield the scheme and domain both as `&str`, so we would still just have a string in the internal proxy field instead of a type-safe value. So I kept the current simple solution that gets the job done and just added the fix.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 17, 2023
Fixes serenity-rs#2322 Probably wouldn't have caused because double slashes are treated by HTTP servers as single slashes in my experience. After a bit of back and forth I opted not to use reqwest methods. Parsing the given proxy in `HttpBuilder` into an `Url` directly means the builder method returns `Result` (or panics) which is both ugly. Also, `Url`'s methods yield the scheme and domain both as `&str`, so we would still just have a string in the internal proxy field instead of a type-safe value. So I kept the current simple solution that gets the job done and just added the fix.
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
Fixes serenity-rs#2322 Probably wouldn't have caused because double slashes are treated by HTTP servers as single slashes in my experience. After a bit of back and forth I opted not to use reqwest methods. Parsing the given proxy in `HttpBuilder` into an `Url` directly means the builder method returns `Result` (or panics) which is both ugly. Also, `Url`'s methods yield the scheme and domain both as `&str`, so we would still just have a string in the internal proxy field instead of a type-safe value. So I kept the current simple solution that gets the job done and just added the fix.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
Fixes serenity-rs#2322 Probably wouldn't have caused because double slashes are treated by HTTP servers as single slashes in my experience. After a bit of back and forth I opted not to use reqwest methods. Parsing the given proxy in `HttpBuilder` into an `Url` directly means the builder method returns `Result` (or panics) which is both ugly. Also, `Url`'s methods yield the scheme and domain both as `&str`, so we would still just have a string in the internal proxy field instead of a type-safe value. So I kept the current simple solution that gets the job done and just added the fix.
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
Fixes serenity-rs#2322 Probably wouldn't have caused because double slashes are treated by HTTP servers as single slashes in my experience. After a bit of back and forth I opted not to use reqwest methods. Parsing the given proxy in `HttpBuilder` into an `Url` directly means the builder method returns `Result` (or panics) which is both ugly. Also, `Url`'s methods yield the scheme and domain both as `&str`, so we would still just have a string in the internal proxy field instead of a type-safe value. So I kept the current simple solution that gets the job done and just added the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2322
Probably wouldn't have caused because double slashes are treated by HTTP servers as single slashes in my experience.
After a bit of back and forth I opted not to use reqwest methods. Parsing the given proxy in HttpBuilder into an Url directly means the builder method returns Result (or panics) which is both ugly. Also, Url's methods yield the scheme and domain both as &str, so we would still just have a string in the internal proxy field instead of a type-safe value. So I kept the current simple solution that gets the job done and just added the fix