Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slight ShardRunner loop cleanup #2387

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Slight ShardRunner loop cleanup #2387

merged 3 commits into from
Apr 18, 2023

Conversation

kangalio
Copy link
Collaborator

See the individual commits

@github-actions github-actions bot added the gateway Related to the `gateway` module. label Apr 17, 2023
@kangalio
Copy link
Collaborator Author

Breaking changes:

  • ShardManager:
    • shard_update method renamed to update_shard_latency_and_stage
  • Shard:
    • heartbeat_instants method removed in favor of the more specific last_heartbeat_sent and last_heartbeat_ack
    • last_heartbeat_sent and last_heartbeat_ack return type changed from Option<&Instant> to Option<Instant>
    • heartbeat_interval return type changed from Option<&u64> to Option<Duration>
    • check_heartbeat method renamed to do_heartbeat

@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Apr 18, 2023
@arqunis arqunis merged commit b74b2f9 into serenity-rs:next Apr 18, 2023
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 18, 2023
@kangalio @mkrasnitski
Slightly clean up ShardRunner loop (serenity-rs#2387)
9f86ca8 
Breaking changes:
- `ShardManager`:
    - `shard_update` method renamed to `update_shard_latency_and_stage`
- `Shard`:
    - `heartbeat_instants` method removed in favor of the more specific `last_heartbeat_sent` and `last_heartbeat_ack`
    - `last_heartbeat_sent` and `last_heartbeat_ack` return type changed from `Option<&Instant>` to `Option<Instant>`
    - `heartbeat_interval` return type changed from `Option<&u64>` to `Option<Duration>`
    - `check_heartbeat` method renamed to `do_heartbeat`
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 19, 2023
@kangalio @mkrasnitski
Slightly clean up ShardRunner loop (serenity-rs#2387)
fb21acc 
Breaking changes:
- `ShardManager`:
    - `shard_update` method renamed to `update_shard_latency_and_stage`
- `Shard`:
    - `heartbeat_instants` method removed in favor of the more specific `last_heartbeat_sent` and `last_heartbeat_ack`
    - `last_heartbeat_sent` and `last_heartbeat_ack` return type changed from `Option<&Instant>` to `Option<Instant>`
    - `heartbeat_interval` return type changed from `Option<&u64>` to `Option<Duration>`
    - `check_heartbeat` method renamed to `do_heartbeat`
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 30, 2023
@kangalio @mkrasnitski
Slightly clean up ShardRunner loop (serenity-rs#2387)
adde418 
Breaking changes:
- `ShardManager`:
    - `shard_update` method renamed to `update_shard_latency_and_stage`
- `Shard`:
    - `heartbeat_instants` method removed in favor of the more specific `last_heartbeat_sent` and `last_heartbeat_ack`
    - `last_heartbeat_sent` and `last_heartbeat_ack` return type changed from `Option<&Instant>` to `Option<Instant>`
    - `heartbeat_interval` return type changed from `Option<&u64>` to `Option<Duration>`
    - `check_heartbeat` method renamed to `do_heartbeat`
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
@kangalio @mkrasnitski
Slightly clean up ShardRunner loop (serenity-rs#2387)
da42cd2 
Breaking changes:
- `ShardManager`:
    - `shard_update` method renamed to `update_shard_latency_and_stage`
- `Shard`:
    - `heartbeat_instants` method removed in favor of the more specific `last_heartbeat_sent` and `last_heartbeat_ack`
    - `last_heartbeat_sent` and `last_heartbeat_ack` return type changed from `Option<&Instant>` to `Option<Instant>`
    - `heartbeat_interval` return type changed from `Option<&u64>` to `Option<Duration>`
    - `check_heartbeat` method renamed to `do_heartbeat`
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
@kangalio @mkrasnitski
Slightly clean up ShardRunner loop (serenity-rs#2387)
6063561 
Breaking changes:
- `ShardManager`:
    - `shard_update` method renamed to `update_shard_latency_and_stage`
- `Shard`:
    - `heartbeat_instants` method removed in favor of the more specific `last_heartbeat_sent` and `last_heartbeat_ack`
    - `last_heartbeat_sent` and `last_heartbeat_ack` return type changed from `Option<&Instant>` to `Option<Instant>`
    - `heartbeat_interval` return type changed from `Option<&u64>` to `Option<Duration>`
    - `check_heartbeat` method renamed to `do_heartbeat`
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
@kangalio @mkrasnitski
Slightly clean up ShardRunner loop (serenity-rs#2387)
1f27d34 
Breaking changes:
- `ShardManager`:
    - `shard_update` method renamed to `update_shard_latency_and_stage`
- `Shard`:
    - `heartbeat_instants` method removed in favor of the more specific `last_heartbeat_sent` and `last_heartbeat_ack`
    - `last_heartbeat_sent` and `last_heartbeat_ack` return type changed from `Option<&Instant>` to `Option<Instant>`
    - `heartbeat_interval` return type changed from `Option<&u64>` to `Option<Duration>`
    - `check_heartbeat` method renamed to `do_heartbeat`
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@kangalio @arqunis
Slightly clean up ShardRunner loop (serenity-rs#2387)
0fc2a2c 
Breaking changes:
- `ShardManager`:
    - `shard_update` method renamed to `update_shard_latency_and_stage`
- `Shard`:
    - `heartbeat_instants` method removed in favor of the more specific `last_heartbeat_sent` and `last_heartbeat_ack`
    - `last_heartbeat_sent` and `last_heartbeat_ack` return type changed from `Option<&Instant>` to `Option<Instant>`
    - `heartbeat_interval` return type changed from `Option<&u64>` to `Option<Duration>`
    - `check_heartbeat` method renamed to `do_heartbeat`
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
@kangalio @arqunis
Slightly clean up ShardRunner loop (serenity-rs#2387)
462655b 
Breaking changes:
- `ShardManager`:
    - `shard_update` method renamed to `update_shard_latency_and_stage`
- `Shard`:
    - `heartbeat_instants` method removed in favor of the more specific `last_heartbeat_sent` and `last_heartbeat_ack`
    - `last_heartbeat_sent` and `last_heartbeat_ack` return type changed from `Option<&Instant>` to `Option<Instant>`
    - `heartbeat_interval` return type changed from `Option<&u64>` to `Option<Duration>`
    - `check_heartbeat` method renamed to `do_heartbeat`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users enhancement An improvement to Serenity. gateway Related to the `gateway` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kangalio @arqunis