Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing field "waveform" error #2402

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

kangalio
Copy link
Collaborator

Introduced by #2392

Due to an annoying serde-derive footgun serde-rs/serde#2249 (comment)

Due to an annoying serde-derive footgun serde-rs/serde#2249 (comment)

I wish someone forked serde-derive and makes a couple breaking updates to fix the footguns and missing features
@github-actions github-actions bot added the model Related to the `model` module. label Apr 26, 2023
@arqunis arqunis added the fix A solution to an existing bug. label Apr 27, 2023
@arqunis arqunis merged commit e91ade7 into serenity-rs:next Apr 27, 2023
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 18, 2023
This was overlooked due to an annoying serde-derive footgun: serde-rs/serde#2249 (comment)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 19, 2023
This was overlooked due to an annoying serde-derive footgun: serde-rs/serde#2249 (comment)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request May 30, 2023
This was overlooked due to an annoying serde-derive footgun: serde-rs/serde#2249 (comment)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Sep 21, 2023
This was overlooked due to an annoying serde-derive footgun: serde-rs/serde#2249 (comment)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 17, 2023
This was overlooked due to an annoying serde-derive footgun: serde-rs/serde#2249 (comment)
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Oct 24, 2023
This was overlooked due to an annoying serde-derive footgun: serde-rs/serde#2249 (comment)
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
This was overlooked due to an annoying serde-derive footgun: serde-rs/serde#2249 (comment)
arqunis pushed a commit to arqunis/serenity that referenced this pull request Oct 24, 2023
This was overlooked due to an annoying serde-derive footgun: serde-rs/serde#2249 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A solution to an existing bug. model Related to the `model` module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants