Sync builders with Discord API #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort fields and remove username and avatar_url because those are only supported in webhooks
Replaced EditWebhookMessage's methods with EditInteractionResponse's ones (they function the same) and make EditInteractionResponse delegate
They're same according to Discord
And remove Default impl in favor of a `fn new()` because it has two required fields
Should have been part of the model sync PR but I somehow misesd it
github-actions
bot
added
builder
arqunis
added
enhancement
|
Merge conflicts fixed (was this the blocker?) |
arqunis
approved these changes
May 11, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 18, 2023
* Add a bunch of CreateChannel fields
* Add a bunch of EditChannel fields
* Make CreateEmbed{Author, Footer} into newtypes
* Add CreateCommand::nsfw and sort fields
* CreateInteractionResponseFollowup
Sort fields and remove username and avatar_url because those are only supported in webhooks
* Make EditInteractionResponse newtype over EditWebhookMessage
Replaced EditWebhookMessage's methods with EditInteractionResponse's ones (they function the same) and make EditInteractionResponse delegate
* Make AutocompleteChoice alias to CommandOptionChoice
They're same according to Discord
* Add CreateMessage::nonce
* Sort CreateScheduledEvent fields
* Add CreateStageInstance::privacy_level
* CreateSticker: remove optional fields from constructor
* Make CreateGuildWelcomeChannel newtype
* Add EditGuild::premium_progress_bar_enabled
* Add EditMember::flags
* Add EditScheduledEvent::privacy_level
* Add EditStageInstance::privacy_level
* Add EditThread::{rate_limit_per_user, flags}
* Add ExecuteWebhook::thread_name
* Fix WebhookIncomming misspelling
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 19, 2023
* Add a bunch of CreateChannel fields
* Add a bunch of EditChannel fields
* Make CreateEmbed{Author, Footer} into newtypes
* Add CreateCommand::nsfw and sort fields
* CreateInteractionResponseFollowup
Sort fields and remove username and avatar_url because those are only supported in webhooks
* Make EditInteractionResponse newtype over EditWebhookMessage
Replaced EditWebhookMessage's methods with EditInteractionResponse's ones (they function the same) and make EditInteractionResponse delegate
* Make AutocompleteChoice alias to CommandOptionChoice
They're same according to Discord
* Add CreateMessage::nonce
* Sort CreateScheduledEvent fields
* Add CreateStageInstance::privacy_level
* CreateSticker: remove optional fields from constructor
* Make CreateGuildWelcomeChannel newtype
* Add EditGuild::premium_progress_bar_enabled
* Add EditMember::flags
* Add EditScheduledEvent::privacy_level
* Add EditStageInstance::privacy_level
* Add EditThread::{rate_limit_per_user, flags}
* Add ExecuteWebhook::thread_name
* Fix WebhookIncomming misspelling
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 30, 2023
* Add a bunch of CreateChannel fields
* Add a bunch of EditChannel fields
* Make CreateEmbed{Author, Footer} into newtypes
* Add CreateCommand::nsfw and sort fields
* CreateInteractionResponseFollowup
Sort fields and remove username and avatar_url because those are only supported in webhooks
* Make EditInteractionResponse newtype over EditWebhookMessage
Replaced EditWebhookMessage's methods with EditInteractionResponse's ones (they function the same) and make EditInteractionResponse delegate
* Make AutocompleteChoice alias to CommandOptionChoice
They're same according to Discord
* Add CreateMessage::nonce
* Sort CreateScheduledEvent fields
* Add CreateStageInstance::privacy_level
* CreateSticker: remove optional fields from constructor
* Make CreateGuildWelcomeChannel newtype
* Add EditGuild::premium_progress_bar_enabled
* Add EditMember::flags
* Add EditScheduledEvent::privacy_level
* Add EditStageInstance::privacy_level
* Add EditThread::{rate_limit_per_user, flags}
* Add ExecuteWebhook::thread_name
* Fix WebhookIncomming misspelling
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
* Add a bunch of CreateChannel fields
* Add a bunch of EditChannel fields
* Make CreateEmbed{Author, Footer} into newtypes
* Add CreateCommand::nsfw and sort fields
* CreateInteractionResponseFollowup
Sort fields and remove username and avatar_url because those are only supported in webhooks
* Make EditInteractionResponse newtype over EditWebhookMessage
Replaced EditWebhookMessage's methods with EditInteractionResponse's ones (they function the same) and make EditInteractionResponse delegate
* Make AutocompleteChoice alias to CommandOptionChoice
They're same according to Discord
* Add CreateMessage::nonce
* Sort CreateScheduledEvent fields
* Add CreateStageInstance::privacy_level
* CreateSticker: remove optional fields from constructor
* Make CreateGuildWelcomeChannel newtype
* Add EditGuild::premium_progress_bar_enabled
* Add EditMember::flags
* Add EditScheduledEvent::privacy_level
* Add EditStageInstance::privacy_level
* Add EditThread::{rate_limit_per_user, flags}
* Add ExecuteWebhook::thread_name
* Fix WebhookIncomming misspelling
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 17, 2023
* Add a bunch of CreateChannel fields
* Add a bunch of EditChannel fields
* Make CreateEmbed{Author, Footer} into newtypes
* Add CreateCommand::nsfw and sort fields
* CreateInteractionResponseFollowup
Sort fields and remove username and avatar_url because those are only supported in webhooks
* Make EditInteractionResponse newtype over EditWebhookMessage
Replaced EditWebhookMessage's methods with EditInteractionResponse's ones (they function the same) and make EditInteractionResponse delegate
* Make AutocompleteChoice alias to CommandOptionChoice
They're same according to Discord
* Add CreateMessage::nonce
* Sort CreateScheduledEvent fields
* Add CreateStageInstance::privacy_level
* CreateSticker: remove optional fields from constructor
* Make CreateGuildWelcomeChannel newtype
* Add EditGuild::premium_progress_bar_enabled
* Add EditMember::flags
* Add EditScheduledEvent::privacy_level
* Add EditStageInstance::privacy_level
* Add EditThread::{rate_limit_per_user, flags}
* Add ExecuteWebhook::thread_name
* Fix WebhookIncomming misspelling
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
* Add a bunch of CreateChannel fields
* Add a bunch of EditChannel fields
* Make CreateEmbed{Author, Footer} into newtypes
* Add CreateCommand::nsfw and sort fields
* CreateInteractionResponseFollowup
Sort fields and remove username and avatar_url because those are only supported in webhooks
* Make EditInteractionResponse newtype over EditWebhookMessage
Replaced EditWebhookMessage's methods with EditInteractionResponse's ones (they function the same) and make EditInteractionResponse delegate
* Make AutocompleteChoice alias to CommandOptionChoice
They're same according to Discord
* Add CreateMessage::nonce
* Sort CreateScheduledEvent fields
* Add CreateStageInstance::privacy_level
* CreateSticker: remove optional fields from constructor
* Make CreateGuildWelcomeChannel newtype
* Add EditGuild::premium_progress_bar_enabled
* Add EditMember::flags
* Add EditScheduledEvent::privacy_level
* Add EditStageInstance::privacy_level
* Add EditThread::{rate_limit_per_user, flags}
* Add ExecuteWebhook::thread_name
* Fix WebhookIncomming misspelling
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
* Add a bunch of CreateChannel fields
* Add a bunch of EditChannel fields
* Make CreateEmbed{Author, Footer} into newtypes
* Add CreateCommand::nsfw and sort fields
* CreateInteractionResponseFollowup
Sort fields and remove username and avatar_url because those are only supported in webhooks
* Make EditInteractionResponse newtype over EditWebhookMessage
Replaced EditWebhookMessage's methods with EditInteractionResponse's ones (they function the same) and make EditInteractionResponse delegate
* Make AutocompleteChoice alias to CommandOptionChoice
They're same according to Discord
* Add CreateMessage::nonce
* Sort CreateScheduledEvent fields
* Add CreateStageInstance::privacy_level
* CreateSticker: remove optional fields from constructor
* Make CreateGuildWelcomeChannel newtype
* Add EditGuild::premium_progress_bar_enabled
* Add EditMember::flags
* Add EditScheduledEvent::privacy_level
* Add EditStageInstance::privacy_level
* Add EditThread::{rate_limit_per_user, flags}
* Add ExecuteWebhook::thread_name
* Fix WebhookIncomming misspelling
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
* Add a bunch of CreateChannel fields
* Add a bunch of EditChannel fields
* Make CreateEmbed{Author, Footer} into newtypes
* Add CreateCommand::nsfw and sort fields
* CreateInteractionResponseFollowup
Sort fields and remove username and avatar_url because those are only supported in webhooks
* Make EditInteractionResponse newtype over EditWebhookMessage
Replaced EditWebhookMessage's methods with EditInteractionResponse's ones (they function the same) and make EditInteractionResponse delegate
* Make AutocompleteChoice alias to CommandOptionChoice
They're same according to Discord
* Add CreateMessage::nonce
* Sort CreateScheduledEvent fields
* Add CreateStageInstance::privacy_level
* CreateSticker: remove optional fields from constructor
* Make CreateGuildWelcomeChannel newtype
* Add EditGuild::premium_progress_bar_enabled
* Add EditMember::flags
* Add EditScheduledEvent::privacy_level
* Add EditStageInstance::privacy_level
* Add EditThread::{rate_limit_per_user, flags}
* Add ExecuteWebhook::thread_name
* Fix WebhookIncomming misspelling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to #2393 but with
serenity::builder::*. Not quite as large of a PR, luckilyFixes #2398
I have skipped the whole topic of message attachments for now, but I will add it later. Once that happens, this PR also fixes #2412
EDIT: nevermind, I noticed all message sending builders already supported files on
next(#2412 is aboutcurrentnot having them):CreateMessagehasadd_file,add_files,filesCreateInteractionResponseMessagehasadd_file,add_files,filesExecuteWebhookhasadd_file,add_files,filesEditMessagehasattachment,keep_existing_attachment,remove_existing_attachmentEditInteractionResponsehasnew_attachment,clear_existing_attachments,keep_existing_attachmentEditWebhookMessagehasnew_attachment,clear_existing_attachments,keep_existing_attachment