Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to i64 in methods associated with CreateCommandOption #2668

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Switch to i64 in methods associated with CreateCommandOption #2668

merged 1 commit into from
Dec 22, 2023

Conversation

ARandomDev99
Copy link

This commit:

  • switched from u64 to i64 in CreateCommandOption::min_int_value and CreateCommandOption::max_int_value to accommodate negative integers in Discord's integer range (between -2^53 and 2^53). Values outside this range will cause Discord's API to return an error.
  • switched from i32 to i64 in CreateCommandOption::add_int_choice and CreateCommandOption::add_int_choice_localized to accommodate Discord's complete integer range (between -2^53 and 2^53). Values outside this range will cause Discord's API to return an error.

@github-actions github-actions bot added the builder Related to the `builder` module. label Dec 21, 2023
@ARandomDev99 ARandomDev99 mentioned this pull request Dec 21, 2023
Closed
@ARandomDev99 ARandomDev99 changed the title Switched to i64 in methods associated with CreateCommandOption Switch to i64 in methods associated with CreateCommandOption Dec 22, 2023
@ARandomDev99
Switch to i64 in methods associated with CreateCommandOption
bea3b3b 
This commit:

- switched from u64 to i64 in CreateCommandOption::min_int_value and CreateCommandOption::max_int_value to accomodate negative integers in Discord's integer range (between -2^53 and 2^53). Values outside this range will cause Discord's API to return an error.
- switched from i32 to i64 in CreateCommandOption::add_int_choice and CreateCommandOption::add_int_choice_localized to accomodate Discord's complete integer range (between -2^53 and 2^53). Values outside this range will cause Discord's API to return an error.
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Dec 22, 2023
@arqunis arqunis merged commit 6402fe1 into serenity-rs:next Dec 22, 2023
22 checks passed
arqunis pushed a commit to arqunis/serenity that referenced this pull request Dec 28, 2023
@ARandomDev99 @arqunis
Switch to i64 in methods associated with CreateCommandOption (ser…
571bc7f 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 2, 2024
@ARandomDev99 @arqunis
Switch to i64 in methods associated with CreateCommandOption (ser…
78f170f 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 5, 2024
@ARandomDev99 @arqunis
Switch to i64 in methods associated with CreateCommandOption (ser…
acd8058 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2024
@ARandomDev99 @arqunis
Switch to i64 in methods associated with CreateCommandOption (ser…
3a46db2 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 22, 2024
@ARandomDev99 @arqunis
Switch to i64 in methods associated with CreateCommandOption (ser…
1fbf27d 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request Feb 9, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
530c9b0 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Mar 1, 2024
@ARandomDev99 @arqunis
Switch to i64 in methods associated with CreateCommandOption (ser…
d541b3a 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request Mar 10, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
5a1b49f 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request Mar 11, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
039eaf7 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request Mar 11, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
e80a277 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (ser…
dc05cdc 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request Mar 13, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
136d7e7 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (ser…
a0776d0 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (ser…
a614253 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request Mar 21, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
e951773 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request Mar 25, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
c74e230 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request Mar 29, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
0630992 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request Mar 31, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
0bd4577 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (ser…
7f3b1d3 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (ser…
5cf793b 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (ser…
5d9583f 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request May 14, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
7806019 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request May 23, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
e9156ce 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request May 28, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
5053bba 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (ser…
686c5dc 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request Jun 22, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
2747c3a 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (ser…
0718317 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@ARandomDev99 @mkrasnitski
Switch to i64 in methods associated with CreateCommandOption (ser…
a95de99 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@ARandomDev99 @mkrasnitski
Switch to i64 in methods associated with CreateCommandOption (ser…
9f2821a 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request Aug 16, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
af3e118 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (ser…
ba12c5d 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (ser…
aa93394 
…enity-rs#2668)

This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
GnomedDev pushed a commit that referenced this pull request Oct 20, 2024
@ARandomDev99 @GnomedDev
Switch to i64 in methods associated with CreateCommandOption (#2668)
57a0bda 
This commit:

- switches from `u64` to `i64` in `CreateCommandOption::min_int_value` and
`CreateCommandOption::max_int_value` to accommodate negative integers in
Discord's integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
- switches from `i32` to `i64` in `CreateCommandOption::add_int_choice` and
`CreateCommandOption::add_int_choice_localized` to accommodate Discord's
complete integer range (between -2^53 and 2^53). Values outside this
range will cause Discord's API to return an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users builder Related to the `builder` module. enhancement An improvement to Serenity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ARandomDev99 @arqunis