Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of unsafe in serenity #2686

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Get rid of unsafe in serenity #2686

merged 1 commit into from
Jan 3, 2024

Conversation

GnomedDev
Copy link
Member

@GnomedDev GnomedDev commented Jan 3, 2024 •
edited
Loading

A discord bot library should not be using the tools reserved for low level OS interaction/data structure libraries..

@github-actions github-actions bot added model Related to the `model` module. http Related to the `http` module. command_attr Related to the `command_attr` crate. labels Jan 3, 2024
@arqunis arqunis added the enhancement An improvement to Serenity. label Jan 3, 2024
@arqunis arqunis merged commit 82be418 into serenity-rs:next Jan 3, 2024
22 checks passed
@GnomedDev GnomedDev deleted the no-unsafe branch January 3, 2024 18:59
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 5, 2024
@GnomedDev @arqunis
Get rid of unsafe (serenity-rs#2686)
22983b7 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 16, 2024
@GnomedDev @arqunis
Get rid of unsafe (serenity-rs#2686)
885630d 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 22, 2024
@GnomedDev @arqunis
Get rid of unsafe (serenity-rs#2686)
4cb59e8 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request Feb 9, 2024
@GnomedDev
Get rid of unsafe (#2686)
7e3c7fa 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Mar 1, 2024
@GnomedDev @arqunis
Get rid of unsafe (serenity-rs#2686)
ca350f2 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request Mar 10, 2024
@GnomedDev
Get rid of unsafe (#2686)
0a41fa3 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Get rid of unsafe (#2686)
db5c51f 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Get rid of unsafe (#2686)
802fd60 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@GnomedDev
Get rid of unsafe (serenity-rs#2686)
5ce0ee2 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request Mar 13, 2024
@GnomedDev
Get rid of unsafe (#2686)
32c8097 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Get rid of unsafe (serenity-rs#2686)
bf50c32 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Get rid of unsafe (serenity-rs#2686)
54fffdb 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request Mar 21, 2024
@GnomedDev
Get rid of unsafe (#2686)
e6a04e1 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Get rid of unsafe (#2686)
b817f1e 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Get rid of unsafe (#2686)
6b74e2b 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Get rid of unsafe (#2686)
8353f7c 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Get rid of unsafe (serenity-rs#2686)
55aff51 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Get rid of unsafe (serenity-rs#2686)
f1c6d1e 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Get rid of unsafe (serenity-rs#2686)
55b080d 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Get rid of unsafe (#2686)
bf46cbe 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Get rid of unsafe (#2686)
091f7b8 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Get rid of unsafe (#2686)
492fb62 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Get rid of unsafe (serenity-rs#2686)
22a8ec8 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Get rid of unsafe (#2686)
56c3a5c 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Get rid of unsafe (serenity-rs#2686)
0509853 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Get rid of unsafe (serenity-rs#2686)
e286510 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Get rid of unsafe (serenity-rs#2686)
8b985f2 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Get rid of unsafe (#2686)
a8c8b39 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Get rid of unsafe (serenity-rs#2686)
07b177d 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Get rid of unsafe (serenity-rs#2686)
be2d958 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Get rid of unsafe (#2686)
103e7d6 
A discord bot library should not be using the tools reserved for low
level OS interaction/data structure libraries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
command_attr Related to the `command_attr` crate. enhancement An improvement to Serenity. http Related to the `http` module. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis