Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manual inline attributes #2702

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Remove manual inline attributes #2702

merged 1 commit into from
Jan 10, 2024

Conversation

GnomedDev
Copy link
Member

The compiler knows best as inlining is quite complicated. This should help with compile times, significantly.

@github-actions github-actions bot added framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate model Related to the `model` module. client Related to the `client` module. builder Related to the `builder` module. cache Related to the `cache`-feature. http Related to the `http` module. utils Related to the `utils` module. gateway Related to the `gateway` module. command_attr Related to the `command_attr` crate. labels Jan 9, 2024
@arqunis arqunis added the enhancement An improvement to Serenity. label Jan 10, 2024
@arqunis arqunis merged commit a75aab3 into serenity-rs:next Jan 10, 2024
22 checks passed
@GnomedDev GnomedDev deleted the no-inline branch January 10, 2024 23:09
arqunis pushed a commit that referenced this pull request Jan 16, 2024
@GnomedDev @arqunis
Remove manual #[inline] attributes (#2702)
478bbd5 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Jan 22, 2024
@GnomedDev @arqunis
Remove manual #[inline] attributes (serenity-rs#2702)
c4e69e2 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request Feb 9, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
ca27259 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
arqunis pushed a commit to arqunis/serenity that referenced this pull request Mar 1, 2024
@GnomedDev @arqunis
Remove manual #[inline] attributes (serenity-rs#2702)
d90ee20 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request Mar 10, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
c84d590 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
4f253cf 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
820a91a 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@GnomedDev
Remove manual #[inline] attributes (serenity-rs#2702)
1e316e4 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request Mar 13, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
9c27fe6 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Remove manual #[inline] attributes (serenity-rs#2702)
c27c488 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Remove manual #[inline] attributes (serenity-rs#2702)
b403f67 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request Mar 21, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
315fe50 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
0ea0ada 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
30aed60 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
0bf8e03 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Remove manual #[inline] attributes (serenity-rs#2702)
121a10f 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Remove manual #[inline] attributes (serenity-rs#2702)
5b09468 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Remove manual #[inline] attributes (serenity-rs#2702)
504dfaf 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
c9dc386 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
b773ba8 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
de505fd 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Remove manual #[inline] attributes (serenity-rs#2702)
49a4580 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
9100a69 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Remove manual #[inline] attributes (serenity-rs#2702)
c9e790d 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Remove manual #[inline] attributes (serenity-rs#2702)
74ac698 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Remove manual #[inline] attributes (serenity-rs#2702)
d63326d 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
fab1e18 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Remove manual #[inline] attributes (serenity-rs#2702)
3b874cb 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Remove manual #[inline] attributes (serenity-rs#2702)
a5566ca 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Remove manual #[inline] attributes (#2702)
c1e6af5 
The compiler knows best as inlining is quite complicated. This should
help with compile times, significantly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
builder Related to the `builder` module. cache Related to the `cache`-feature. client Related to the `client` module. command_attr Related to the `command_attr` crate. enhancement An improvement to Serenity. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate gateway Related to the `gateway` module. http Related to the `http` module. model Related to the `model` module. utils Related to the `utils` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis