Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Member::highest_role_info to Guild::member_highest_role #2816

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Move Member::highest_role_info to Guild::member_highest_role #2816

merged 2 commits into from
Mar 25, 2024

Conversation

GnomedDev
Copy link
Member

This means:

  • PartialGuild::greater_member_hierarchy isn't a duplicate of Guild::greater_member_hierarchy anymore
  • Guild::greater_member_hierarchy doesn't need the cache parameter, and this can be removed in a followup PR to next.
  • Guild::member_highest_role doesn't need cache and can return back a reference to the role, instead of id and position which then required another lookup.

@github-actions github-actions bot added the model Related to the `model` module. label Mar 25, 2024
@arqunis arqunis added the enhancement An improvement to Serenity. label Mar 25, 2024
@arqunis arqunis merged commit d29962d into serenity-rs:current Mar 25, 2024
22 checks passed
@GnomedDev GnomedDev deleted the better-role branch March 25, 2024 20:57
@GnomedDev GnomedDev mentioned this pull request Mar 25, 2024
Merged
arqunis added a commit that referenced this pull request Mar 26, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (#2817)
bc96494 
Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (#2817)
78c884b 
Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (#2817)
69c3cb8 
Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (serenity-rs#2817)
38cde2f 
Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (serenity-rs#2817)
0850f85 
Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (serenity-rs#2817)
fcd79bd 
Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (#2817)
76bf89d 
Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (#2817)
fa8f39d 
Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (#2817)
08db97d 
Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (serenity-rs#2817)
a818c36 
Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (#2817)
5a9339e 
Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (serenity-rs#2817)
8f1a2b0 
Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @arqunis @mkrasnitski
Remove deprecated Member and Guild methods (serenity-rs#2817)
15585e8 
Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @arqunis @mkrasnitski
Remove deprecated Member and Guild methods (serenity-rs#2817)
1864312 
Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (#2817)
386e985 
Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (serenity-rs#2817)
48c9846 
Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (serenity-rs#2817)
c584dee 
Followup to serenity-rs#2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev @arqunis
Remove deprecated Member and Guild methods (#2817)
c0e0771 
Followup to #2816

---------

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
enhancement An improvement to Serenity. model Related to the `model` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis